Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Follow-up of #2808, #2828 & #3081

Things I did extra:

  • Change addedFileToSandbox's signature to get its argument types directly from UploadFile instead of hardcoding them
  • Change deletedUploadedFile's signature to accept a string instead of { id: string }, because it only has 1 argument
  • Refactor Button out of AddFileToSandboxButton & DeleteFileButton
  • Move overmind subscriptions as close as possible to the components itself instead of passing it through
  • Put all styles into the elements.ts file

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 31, 2020
@lbogdan lbogdan temporarily deployed to pr3438 January 31, 2020 13:31 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jan 31, 2020

Build for latest commit 11aba1b is at https://pr3438.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from c7c1ca8 to bccd4d9 Compare January 31, 2020 13:39
@lbogdan lbogdan temporarily deployed to pr3438 January 31, 2020 13:56 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from bccd4d9 to a6df780 Compare February 5, 2020 16:53
@lbogdan lbogdan temporarily deployed to pr3438 February 5, 2020 17:00 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from a6df780 to 461a1e4 Compare February 5, 2020 23:46
@lbogdan lbogdan temporarily deployed to pr3438 February 5, 2020 23:53 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from 461a1e4 to 292c20f Compare February 8, 2020 12:38
@lbogdan lbogdan temporarily deployed to pr3438 February 8, 2020 12:54 Inactive
@SaraVieira
Copy link
Contributor

@MichaelDeBoey Can you please fix the conflicts?

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from 292c20f to b93bde6 Compare February 13, 2020 13:37
@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira Rebased on upstream/master 🙂

@lbogdan lbogdan temporarily deployed to pr3438 February 13, 2020 13:43 Inactive
@SaraVieira
Copy link
Contributor

SaraVieira commented Feb 13, 2020

There is an issue with the buttons :(

Screenshot 2020-02-13 at 15 30 44

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from b93bde6 to b367a64 Compare February 13, 2020 14:42
@lbogdan lbogdan temporarily deployed to pr3438 February 13, 2020 14:48 Inactive
@lbogdan lbogdan temporarily deployed to pr3438 February 13, 2020 15:08 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from ebbac48 to d095d00 Compare February 13, 2020 15:26
@lbogdan lbogdan temporarily deployed to pr3438 February 13, 2020 15:32 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from d095d00 to 6ee8f28 Compare February 13, 2020 21:31
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/StorageManagementModal branch from 6ee8f28 to 11aba1b Compare February 13, 2020 21:37
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SaraVieira SaraVieira merged commit 4f379fd into codesandbox:master Feb 13, 2020
@MichaelDeBoey
Copy link
Contributor Author

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/StorageManagementModal branch February 14, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants