-
Notifications
You must be signed in to change notification settings - Fork 2.4k
🔨 Switch StorageManagementModal to use useOvermind #3438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SaraVieira
merged 4 commits into
codesandbox:master
from
MichaelDeBoey:overmind/StorageManagementModal
Feb 13, 2020
Merged
🔨 Switch StorageManagementModal to use useOvermind #3438
SaraVieira
merged 4 commits into
codesandbox:master
from
MichaelDeBoey:overmind/StorageManagementModal
Feb 13, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit 11aba1b is at https://pr3438.build.csb.dev/s/new. |
c7c1ca8 to
bccd4d9
Compare
bccd4d9 to
a6df780
Compare
a6df780 to
461a1e4
Compare
461a1e4 to
292c20f
Compare
Contributor
|
@MichaelDeBoey Can you please fix the conflicts? |
292c20f to
b93bde6
Compare
Contributor
Author
|
@SaraVieira Rebased on |
Contributor
b93bde6 to
b367a64
Compare
ebbac48 to
d095d00
Compare
d095d00 to
6ee8f28
Compare
6ee8f28 to
11aba1b
Compare
SaraVieira
approved these changes
Feb 13, 2020
Contributor
SaraVieira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Contributor
Author
|
With pleasure! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Follow-up of #2808, #2828 & #3081
Things I did extra:
addedFileToSandbox's signature to get its argument types directly fromUploadFileinstead of hardcoding themdeletedUploadedFile's signature to accept astringinstead of{ id: string }, because it only has 1 argumentButtonout ofAddFileToSandboxButton&DeleteFileButtonovermindsubscriptions as close as possible to the components itself instead of passing it throughelements.tsfile