-
Notifications
You must be signed in to change notification settings - Fork 2.4k
🔨 Switch Project to use useOvermind #3119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Switch Project to use useOvermind #3119
Conversation
a20dab1 to
cbffa27
Compare
|
Build for latest commit 008c3f9 is at https://pr3119.build.csb.dev/s/new. |
cbffa27 to
156719b
Compare
156719b to
008c3f9
Compare
|
Typecheck will pass once DefinitelyTyped/DefinitelyTyped#40894 is merged and |
|
Interesting, why do we include |
|
@MichaelDeBoey Do you mind closing this and splitting it up? 42 files is a lot :( |
|
@CompuIves I included @SaraVieira I can make a new PR where I only have the first commit and a separate PR for the extraction of all the components? |
|
@MichaelDeBoey I think we can get this through as the refactor is scoped to a specific part of the page. We just have to test the Project feature as a whole 😄 Could you just add the type here as well? Just so that we can merge it in without having to wait for the other one? |
|
Oh sorry, it is a different repo... can we get around this? Write a comment ignore the typing or something. Do not want to have this pending, as we do not know when the other one will be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- Open
/s/new, it shows the project view correctly with views, forks, template bookmark, explorer, dependencies etc. - Forked it and opened
SandboxInfo - Change name (alias)
- Changed description
- I see the profile, with the badges and can click to open the profile
- Click "like", I see the views and forks as well
- I can add and remove tags (tested with refresh)
- I can change the privacy setting (tested with refresh)
- Can toggle "frozen" (tested with refresh)
- Template name is there and I can click it
- Environment is there and correct
- Create template works
- I can edit color and icon (tested with refresh)
- Delete template works
- Delete Sandbox works
- Shows team indication when a team Sandbox
|
@MichaelDeBoey Can you get the react color types off and then when thats merged we can add it? Wanna get a bunch of these things in this month :) |
|
I deleted the @types/react-color and merged it :) Good luck with thier pr 🎉 |
Resubmission of #2843
Follow-up of #2782
Things I did extra:
sandboxPrivacyChanged's signature to accept0 | 1 | 2instead of{ privacy: 0 | 1 | 2 }, because it only has 1 argumentelements.tsfileovermindsubscriptions as close as possible to the components itself instead of passing it throughEnvironment,ForkedFrom,Git,Privacy,PrivacyNotice&Teamout ofProjectFunctionComponentinstead ofReact.FC, since it's the same, butFunctionComponentis a bit clearer I think