🔨 Switch Badges to use useOvermind #3072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Contributor
|
Build for latest commit 7da3616 is at https://pr3072.build.csb.dev/s/new. |
christianalfoni
approved these changes
Nov 28, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
Looks great! 😄 👍
Tested:
- Open badges in preferences
- Toggled it and refreshed, it saves
- Double checked it looks the same on codesandbox.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2760
Things I did extra:
setBadgeVisibility's signature to get its argument types directly fromBadgeinstead of hardcoding thembadges.lengthinstead of an extrabadgesCountvariableBadge'sonClickprop a bit