🔨 Switch SignOutNoticeModal to use useOvermind #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Contributor
|
Build for latest commit 71807ed is at https://pr3062.build.csb.dev/s/new. |
MichaelDeBoey
force-pushed
the
overmind/SignOutNoticeModal
branch
from
fbeca3c to
80a1b52
Compare
MichaelDeBoey
force-pushed
the
overmind/SignOutNoticeModal
branch
from
80a1b52 to
f6dc3a5
Compare
MichaelDeBoey
force-pushed
the
overmind/SignOutNoticeModal
branch
2 times, most recently
from
c73804b to
9fab940
Compare
MichaelDeBoey
force-pushed
the
overmind/SignOutNoticeModal
branch
from
9fab940 to
71807ed
Compare
SaraVieira
approved these changes
Dec 8, 2019
Contributor
|
Awesome! Thank you! |
Contributor
Author
|
With pleasure! 🙂 @SaraVieira I'll create a new PR to delete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2655
Things I did extra:
elements.tsfileSignOutNoticeModalaFunctionComponentI think this component (
SignOutNoticeModal) can be deleted tho, since it's not used anymore? 🤔