🔨 Refactor, 🧠 Overmind Hactoberfest | Refactor /app/pages/Sandbox/Editor/Workspace/Chat/index.js to use Overmind and Typescript #2910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevhenorlov
commented
Oct 23, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Chat/index.tsx
Outdated
Show resolved
Hide resolved
yevhenorlov
commented
Oct 23, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Chat/index.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Build for latest commit d059961 is at https://pr2910.build.csb.dev/s/new. |
84 tasks
christianalfoni
requested changes
Oct 23, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Chat/index.tsx
Outdated
Show resolved
Hide resolved
christianalfoni
approved these changes
Oct 24, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
Looks great! 👍 Tested:
- Activate chat
- Send messages
- Join new user
- Send messages from new user
- Collapse/expand chat
- Turn off chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Changing
Chatcomponent to use Typescript and Overmind as part of #2621 @Saeris @christianalfoniWhat is the current behavior?
Chatcomponent usesinjectandobserverand does not benefit from types.What is the new behavior?
Chatcomponent usesuseOvermindand Typescript.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
yarn lintyarn testWasn't able to open the component locally, so no manual testing unfortunately.
Checklist
I ran into some issues with Typescript, also it would be great to have someone take a look at the class-to-functional-component change - in particular, I'm not 100% sure about my ref implementation.
I'll mark the pain points in code additionally.