Skip to content

Conversation

@neochaochaos
Copy link
Contributor

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

package /app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/DirectoryChildren/index.js was using Cerebral

What is the new behavior?

packages /app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/DirectoryChildren/index.tsx is using Overmind

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. yarn test
  2. yarn lint
  3. yarn typecheck

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@lbogdan
Copy link
Contributor

lbogdan commented Oct 20, 2019

Build for latest commit f55dc4e is at https://pr2885.build.csb.dev/s/new.

@SaraVieira
Copy link
Contributor

Hey!

I am so osrry for the delay in this PR :(

It looks awesome!
Thank you so much

@SaraVieira SaraVieira merged commit efc23ba into codesandbox:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants