refactored content editor tabs packages/app/src/app/pages/Sandbox/Editor/Content/Tabs/index.tsx #2881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusan
changed the title
Contributor
|
Build for latest commit d5404f7 is at https://pr2881.build.csb.dev/s/new. |
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
84 tasks
Contributor
Author
|
Hi @Saeris I am sure the team must be burdened with a lot of PRs! |
Contributor
|
Hi there! Thanks for the work here. It turns out we are not using the component anymore, but I will merge it nevertheless for your hard work 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni
What is the current behavior?
packages/app/src/app/pages/Sandbox/Editor/Content/Tabs/index.js was using Cerebral.
packages/app/src/app/pages/Sandbox/Editor/Content/Tabs/elements.js was not in TS.
What is the new behavior?
packages/app/src/app/pages/Sandbox/Editor/Content/Tabs/index.tsx is using Overmind.
packages/app/src/app/pages/Sandbox/Editor/Content/Tabs/elements.js is in TS. I had to convert it to TS to fix linting errors for Tabs/index.js.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist