From 4be691c46eabd35a5665c3df120436a036e50dfc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20De=20Boey?= <info@michaeldeboey.be>
Date: Thu, 3 Oct 2019 15:16:17 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A8=20Switch=20DashboardChangelog=20to?=
 =?UTF-8?q?=20use=20useOvermind?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../Dashboard/{Helmet.js => Helmet.tsx}       |  0
 .../Modals/Changelog/Dashboard/index.tsx      | 37 +++++++++++--------
 .../common/src/components/Button/index.tsx    | 18 ++++++---
 3 files changed, 34 insertions(+), 21 deletions(-)
 rename packages/app/src/app/pages/common/Modals/Changelog/Dashboard/{Helmet.js => Helmet.tsx} (100%)

diff --git a/packages/app/src/app/pages/common/Modals/Changelog/Dashboard/Helmet.js b/packages/app/src/app/pages/common/Modals/Changelog/Dashboard/Helmet.tsx
similarity index 100%
rename from packages/app/src/app/pages/common/Modals/Changelog/Dashboard/Helmet.js
rename to packages/app/src/app/pages/common/Modals/Changelog/Dashboard/Helmet.tsx
diff --git a/packages/app/src/app/pages/common/Modals/Changelog/Dashboard/index.tsx b/packages/app/src/app/pages/common/Modals/Changelog/Dashboard/index.tsx
index 6f4d42b405a..0a2345c5a5d 100644
--- a/packages/app/src/app/pages/common/Modals/Changelog/Dashboard/index.tsx
+++ b/packages/app/src/app/pages/common/Modals/Changelog/Dashboard/index.tsx
@@ -1,9 +1,10 @@
-import React, { FunctionComponent } from 'react';
 import CSS from 'csstype';
-import { useOvermind } from 'app/overmind';
-import { Link } from 'react-router-dom';
 import theme from '@codesandbox/common/lib/theme';
 import { Button } from '@codesandbox/common/lib/components/Button';
+import React, { FunctionComponent } from 'react';
+import { Link } from 'react-router-dom';
+
+import { useOvermind } from 'app/overmind';
 
 // Inline styles because styled-components didn't load the styles
 const titleStyles: CSS.Properties = {
@@ -53,32 +54,33 @@ export const DashboardChangelog: FunctionComponent = () => {
   return (
     <div
       style={{
-        padding: '1.5rem',
         backgroundColor: theme.background(),
+        padding: '1.5rem',
       }}
     >
       <div
         style={{
-          marginBottom: '1rem',
-          display: 'flex',
           alignItems: 'center',
+          display: 'flex',
+          marginBottom: '1rem',
         }}
       >
         <h1 style={titleStyles}>
           What
           {"'"}s New
         </h1>
+
         <div style={dateStyles}>July 2nd, 2018</div>
       </div>
 
       <img
         alt="CodeSandbox Announcement"
+        src="https://cdn-images-1.medium.com/max/1600/1*wIMw31_Phf1WNEP6zjuTUw.png"
         style={{
           width: '100%',
           backgroundColor: 'rgba(0, 0, 0, 0.3)',
           borderRadius: 2,
         }}
-        src="https://cdn-images-1.medium.com/max/1600/1*wIMw31_Phf1WNEP6zjuTUw.png"
       />
 
       <p style={descriptionStyles}>
@@ -90,6 +92,7 @@ export const DashboardChangelog: FunctionComponent = () => {
       </p>
 
       <h2 style={subTitleStyles}>Dashboard</h2>
+
       <p style={descriptionStyles}>
         You can now manage your sandboxes in your own{' '}
         <Link to="/dashboard">dashboard</Link>! You
@@ -99,6 +102,7 @@ export const DashboardChangelog: FunctionComponent = () => {
       </p>
 
       <h2 style={subTitleStyles}>Create Teams</h2>
+
       <p style={descriptionStyles}>
         An extension to the dashboard is <W>teams</W>! You can now create a team
         with unlimited members to share sandboxes for collaboration. All
@@ -107,6 +111,7 @@ export const DashboardChangelog: FunctionComponent = () => {
       </p>
 
       <h2 style={subTitleStyles}>Free CodeSandbox Live</h2>
+
       <p style={descriptionStyles}>
         Teams is not our only feature that allows for collaboration. We also
         have <W>real time collaboration</W> with{' '}
@@ -124,6 +129,7 @@ export const DashboardChangelog: FunctionComponent = () => {
       </p>
 
       <h2 style={subTitleStyles}>And More</h2>
+
       <p style={descriptionStyles}>
         There
         {"'"}s a lot more included in this update! Make sure to check out the
@@ -132,23 +138,24 @@ export const DashboardChangelog: FunctionComponent = () => {
 
       <div style={{ display: 'flex' }}>
         <Button
-          style={{ marginTop: '1rem', marginRight: '.25rem' }}
           block
-          small
-          secondary
           onClick={() => modalClosed()}
+          secondary
+          small
+          style={{ marginTop: '1rem', marginRight: '.25rem' }}
         >
           Close
         </Button>
-        {/* 
-  // @ts-ignore */}
+
+        {/*
+        // @ts-ignore */}
         <Button
-          href="/post/announcing-codesandbox-dashboard-teams"
-          style={{ marginTop: '1rem', marginLeft: '.25rem' }}
           block
+          href="/post/announcing-codesandbox-dashboard-teams"
+          rel="noreferrer noopener"
           small
+          style={{ marginLeft: '.25rem', marginTop: '1rem' }}
           target="_blank"
-          rel="noreferrer noopener"
         >
           View Announcement
         </Button>
diff --git a/packages/common/src/components/Button/index.tsx b/packages/common/src/components/Button/index.tsx
index 732cb10487e..c0f776925cb 100644
--- a/packages/common/src/components/Button/index.tsx
+++ b/packages/common/src/components/Button/index.tsx
@@ -1,4 +1,5 @@
-import React from 'react';
+import React, { FunctionComponent } from 'react';
+
 import { LinkButton, AButton, Button } from './elements';
 
 export type Props = {
@@ -14,19 +15,24 @@ export type Props = {
   danger?: boolean;
   secondary?: boolean;
   red?: boolean;
+  target?: string;
+  rel?: string;
 };
 
-function ButtonComponent({ style = {}, ...props }: Props) {
+const ButtonComponent: FunctionComponent<Props> = ({
+  style = {},
+  ...props
+}) => {
   // Link
   if (props.to) {
-    return <LinkButton style={style} {...props} />;
+    return <LinkButton {...props} style={style} />;
   }
 
   if (props.href) {
-    return <AButton style={style} {...props} />;
+    return <AButton {...props} style={style} />;
   }
 
-  return <Button style={style} {...props} />;
-}
+  return <Button {...props} style={style} />;
+};
 
 export { ButtonComponent as Button };