From 33eca812ec7506ec662808ec50f1a40d807ca0df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adem=C3=ADlson=20F=2E=20Tonato?= Date: Tue, 15 Oct 2019 17:47:42 +0100 Subject: [PATCH 1/5] refactor /app/pages/common/Modals/PRModal/index.js: convert to tsx and uses overmind --- .../app/components/GitProgress/GitProgress.tsx | 6 +++--- .../Modals/PRModal/{index.js => index.tsx} | 18 ++++++++++-------- 2 files changed, 13 insertions(+), 11 deletions(-) rename packages/app/src/app/pages/common/Modals/PRModal/{index.js => index.tsx} (68%) diff --git a/packages/app/src/app/components/GitProgress/GitProgress.tsx b/packages/app/src/app/components/GitProgress/GitProgress.tsx index 701cda72120..87d26cbc8d2 100644 --- a/packages/app/src/app/components/GitProgress/GitProgress.tsx +++ b/packages/app/src/app/components/GitProgress/GitProgress.tsx @@ -1,16 +1,16 @@ import React from 'react'; import { Container, + Cube, DeployAnimationContainer, + DeployText, GitHubLogo, - Cube, OpaqueLogo, - DeployText, Result, } from './elements'; interface IGitProgressProps { - result: string; + result: string | null; message: string; } diff --git a/packages/app/src/app/pages/common/Modals/PRModal/index.js b/packages/app/src/app/pages/common/Modals/PRModal/index.tsx similarity index 68% rename from packages/app/src/app/pages/common/Modals/PRModal/index.js rename to packages/app/src/app/pages/common/Modals/PRModal/index.tsx index fddfb5f39e9..65751b65dee 100644 --- a/packages/app/src/app/pages/common/Modals/PRModal/index.js +++ b/packages/app/src/app/pages/common/Modals/PRModal/index.tsx @@ -1,12 +1,16 @@ -import React from 'react'; -import { inject, observer } from 'app/componentConnectors'; import { GitProgress } from 'app/components/GitProgress'; +import { useOvermind } from 'app/overmind'; +import React, { FunctionComponent } from 'react'; + +export const PRModal: FunctionComponent = () => { + const { + state: { git }, + } = useOvermind(); -function PRModal({ store }) { let result = null; - if (!store.git.isCreatingPr) { - const newUrl = store.git.pr.prURL; + if (!git.isCreatingPr) { + const newUrl = git.pr.prURL; result = (
@@ -27,6 +31,4 @@ function PRModal({ store }) { message="Forking Repository & Creating PR..." /> ); -} - -export default inject('store')(observer(PRModal)); +}; From 04062bd374b42c326bcd3951db295cb936f6e75a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adem=C3=ADlson=20F=2E=20Tonato?= Date: Wed, 16 Oct 2019 11:27:38 +0100 Subject: [PATCH 2/5] refactor /app/pages/common/Modals/LiveSessionEnded/index.js: convert to tsx and uses overmind Co-authored-by: Eliamar Tani --- .../LiveSessionEnded/{index.js => index.tsx} | 37 +++++++++++-------- 1 file changed, 21 insertions(+), 16 deletions(-) rename packages/app/src/app/pages/common/Modals/LiveSessionEnded/{index.js => index.tsx} (58%) diff --git a/packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.js b/packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.tsx similarity index 58% rename from packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.js rename to packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.tsx index dc7d8733a0a..f10025909ed 100644 --- a/packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.js +++ b/packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.tsx @@ -1,22 +1,29 @@ -import React from 'react'; -import { inject, hooksObserver } from 'app/componentConnectors'; - import { Button } from '@codesandbox/common/lib/components/Button'; import Row from '@codesandbox/common/lib/components/flex/Row'; - +import { useOvermind } from 'app/overmind'; +import React, { FunctionComponent } from 'react'; +import { Explanation, Heading } from '../elements'; import { Container } from './elements'; -import { Heading, Explanation } from '../elements'; -function LiveModeEnded({ signals, store }) { - const suggestion = store.editor.currentSandbox.owned +export const LiveModeEnded: FunctionComponent = () => { + const { + state: { editor, currentModalMessage }, + actions: { + modalClosed, + editor: { forkSandboxClicked }, + }, + } = useOvermind(); + + const suggestion = editor.currentSandbox.owned ? 'you can continue working on the current sandbox.' : 'you can continue working by forking the sandbox or by creating a new sandbox.'; + return ( The live session has ended - {store.currentModalMessage || 'The session has ended due to inactivity'} - , {suggestion} + {currentModalMessage || 'The session has ended due to inactivity'},{' '} + {suggestion} @@ -24,11 +31,11 @@ function LiveModeEnded({ signals, store }) { Create Sandbox - {store.editor.currentSandbox.owned ? ( + {editor.currentSandbox.owned ? ( - {store.editor.currentSandbox.owned ? ( + {editor.currentSandbox.owned ? (