Refactors app/src/app/pages/common/Modals/StorageManagementModal/index.js (#2621) #2808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 tasks
christianalfoni
approved these changes
Oct 17, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
Looking great! 👍 We actually found some other bugs when testing this PR so that is great, creating a separate PR to fix those. Awesome work 😄 Also great you catched the required "import" change!
Tested:
- Open storage management
- Check that text is correct
- Delete/add files (currently broken by something else, creating separate PR)
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is part of #2621.
@Saeris @christianalfoni
What kind of change does this PR introduce?
app\pages\common\Modals\PreferencesModal\StorageManagementModal/index.js->app\pages\common\Modals\PreferencesModal\StorageManagementModal/index.tsxWhat is the current behavior?
Currently, the state is passed to the components through app/componentConnectors's inject and observer functions.
What is the new behavior?
The state is now retrieved from the Overmind instance.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist