Skip to content

Conversation

@melugi
Copy link

@melugi melugi commented Oct 15, 2019

This refactor is part of #2621.
@Saeris @christianalfoni

What kind of change does this PR introduce?

  • Renames app\pages\common\Modals\PreferencesModal\Badges\index.js -> app\pages\common\Modals\PreferencesModal\Badges\index.tsx
  • Removes use of inject and hooksObserver and replaces them with useOvermind() to pass state to components.

What is the current behavior?

Currently the state is passed to the components through app/componentConnectors's inject and hooksObserver functions.

What is the new behavior?

The state is now retrieved from the Overmind instance.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. yarn lint
  2. yarn test

I tried verifying that the changes worked well but I couldn't see any way to mock the logged in functionality in the sandbox.

Checklist

  • Documentation N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

Let me know if this needs any more changes!

Edit: I couldn't add the labels for this PR, if someone could help I'd appreciate it.

@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 16, 2019
@Saeris
Copy link
Contributor

Saeris commented Oct 21, 2019

Looks like this is a duplicate. We're reviewing and merging PRs in order of submission, so I'm sorry but I'll have to close this one out since #2760 was submitted earlier. Thanks anyways though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants