Refactors app\pages\common\Modals\PreferencesModal\Badges\index.js (#2621) #2805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is part of #2621.
@Saeris @christianalfoni
What kind of change does this PR introduce?
app\pages\common\Modals\PreferencesModal\Badges\index.js->app\pages\common\Modals\PreferencesModal\Badges\index.tsxinjectandhooksObserverand replaces them withuseOvermind()to pass state to components.What is the current behavior?
Currently the state is passed to the components through
app/componentConnectors'sinjectandhooksObserverfunctions.What is the new behavior?
The state is now retrieved from the Overmind instance.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
yarn lintyarn testI tried verifying that the changes worked well but I couldn't see any way to mock the logged in functionality in the sandbox.
Checklist
Let me know if this needs any more changes!
Edit: I couldn't add the labels for this PR, if someone could help I'd appreciate it.