refactor /app/pages/common/Modals/EmptyTrash/index.js to use OverMind… #2795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and change it to tsx file
christianalfoni
approved these changes
Oct 15, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
This looks great! 😄 👍
Tested:
- Click delete all sandboxes, modal opens
- Close modal
- Delete all sandboxes
84 tasks
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor /app/pages/common/Modals/EmptyTrash/index.js to use OverMind and change the file to tsx file.
What is the current behavior?
It was using cerebral for state management
What is the new behaviour?
It uses Overmind for state management with the help of useOvermind hook
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
yarn testis successfullyarn startis successfullyarn lintandyarn typecheckis successfullChecklist