Skip to content

Conversation

@kalaivanan-muthusamy
Copy link
Contributor

Fixes #2621

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

\app\src\app\pages\Sandbox\Editor\Workspace\Project\Project.tsx was using Cerebral

What is the new behavior?

\app\src\app\pages\Sandbox\Editor\Workspace\Project\Project.tsx now uses Overmind

What steps did you take to test this? This is required before we can merge.

  1. Replaced inject and hooksObserver with useOvermind
  2. yarn test
  3. yarn lint

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 14, 2019 19:43 Inactive
@vercel
Copy link

vercel bot commented Oct 14, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/jf7gk38kc
🌍 Preview: https://codesandbox-client-git-fork-kalaivanan-muthusamy-master.codesandbox1.now.sh

@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 15, 2019
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 😄

Tested:

  • Change name (id)
  • Change description
  • add/remove tag
  • Change privacy
  • Change frozen
  • Delete sandbox
  • Open team sandbox

Unable to test GIT, but it is a simple unchanged check, so think we are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Submissions Closed] Participating in #HacktoberFest? Here's some beginner friendly ways to contribute to CodeSandbox!

3 participants