Skip to content

Conversation

@stackyism
Copy link
Contributor

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni @SaraVieira

What is the current behavior?

/app/pages/Sandbox/Editor/Workspace/items/Deployment/Netlify/SiteInfo/SiteInfo.tsx was using inject and hooksObserver from app/componentConnectors and was failing typecheck while accessing netlifySite.uid as uid is present on ZeitDeployment.

What is the new behavior?

uses useOvermind hook from app/overmind and replaces uid with id present on NetlifySite type.

What steps did you take to test this? This is required before we can merge.

  1. Deployed the codesandbox app locally.
  2. Used Netlify deployment to test Site Info. (Recording)
  3. Ran yarn lint, yarn test & yarn typecheck successfully.

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/ge3khzuck
🌍 Preview: https://codesandbox-clien-git-fork-stackyism-refactor-netlify-si-11da28.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 12, 2019 08:46 Inactive
@Saeris Saeris added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management Hacktoberfest labels Oct 13, 2019
@stackyism
Copy link
Contributor Author

@Saeris @christianalfoni Please let me know if any action is required from my side on this PR.

Thank you for the opportunity. :)

Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent stuff! 👍 😄

Tested:

  • Deploying to Netlify
  • Ensure that it transitions to deployed state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants