-
Notifications
You must be signed in to change notification settings - Fork 2.4k
🔨 Refactored 🧠 Overmind Hacktober | /app/pages/CliInstructions/index.tsx : refactor to replace Cerebral with Overmind #2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Refactored 🧠 Overmind Hacktober | /app/pages/CliInstructions/index.tsx : refactor to replace Cerebral with Overmind #2656
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://codesandbox-client-git-fork-iwgx-refactor-cliinstructions-index.codesandbox1.now.sh |
dc87ba2 to
6e7b07d
Compare
9792e41 to
6e7b07d
Compare
Saeris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just some minor changes to imports I'd like you to fix and then this should be good to go!
|
thanks for your review @Saeris |
|
Heyo! I tested this PR and it seems like it doesn't work, when going to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change default import.
|
Sorry for that, can you check again my latest update? Thanks! @CompuIves |
|
Very nice! Thanks a lot! |

What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni
What is the current behavior?
packages/app/src/app/pages/CliInstructions/index.tsxwas usinginjectandhooksObserverfromapp/componentConnectorsWhat is the new behavior?
uses
useOvermindfromapp/overmindWhat steps did you take to test this?
run
yarn test,yarn typecheckand throughlint-stagedalso tried to run the app withyarn startChecklist