Skip to content

Commit febd1fe

Browse files
Delete all experimentVSCode branches from the code (#3283)
* Delete all experimentVSCode branches from the code * Fix types * Fully delete keybindingManager, since it's not doing anything anymore
1 parent 4f379fd commit febd1fe

File tree

15 files changed

+5
-371
lines changed

15 files changed

+5
-371
lines changed

packages/app/src/app/overmind/actions.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,7 @@ export const modalOpened: Action<{
9090
}
9191
};
9292

93-
export const modalClosed: Action = ({ state, effects }) => {
94-
// We just start it whenever it closes, if already started nothing happens
95-
if (state.currentModal === 'preferences') {
96-
effects.keybindingManager.start();
97-
}
98-
93+
export const modalClosed: Action = ({ state }) => {
9994
state.currentModal = null;
10095
};
10196

packages/app/src/app/overmind/effects/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ export { default as api } from './api';
44
export { default as browser } from './browser';
55
export { default as connection } from './connection';
66
export { default as jsZip } from './jsZip';
7-
export { default as keybindingManager } from './keybindingManager';
87
export { default as live } from './live';
98
export { default as moduleRecover } from './moduleRecover';
109
export { default as notifications } from './notifications';

packages/app/src/app/overmind/effects/keybindingManager.ts

Lines changed: 0 additions & 333 deletions
This file was deleted.

packages/app/src/app/overmind/effects/settingsStore.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const allowedKeys = {
2020
enableLigatures: 'settings.enableLigatures',
2121
customVSCodeTheme: 'settings.customVSCodeTheme',
2222
manualCustomVSCodeTheme: 'settings.manualCustomVSCodeTheme',
23-
// experimentVSCode: 'settings.experimentVSCode',
2423
};
2524

2625
export default {

packages/app/src/app/overmind/factories.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Contributor, PermissionType } from '@codesandbox/common/lib/types';
22
import { hasPermission } from '@codesandbox/common/lib/utils/permission';
3-
import { IDerive, IState, json } from 'overmind';
3+
import { IDerive, IState } from 'overmind';
44

55
import { AsyncAction } from '.';
66

@@ -26,10 +26,6 @@ export const withLoadApp = <T>(
2626

2727
effects.connection.addListener(actions.connectionChanged);
2828
actions.internal.setStoredSettings();
29-
effects.keybindingManager.set(
30-
json(state.preferences.settings.keybindings || []) as any
31-
);
32-
effects.keybindingManager.start();
3329
effects.codesandboxApi.listen(actions.server.onCodeSandboxAPIMessage);
3430

3531
if (state.jwt) {

packages/app/src/app/overmind/internalActions.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ export const closeModals: Action<boolean> = ({ state, effects }, isKeyDown) => {
170170
}
171171

172172
state.currentModal = null;
173-
effects.keybindingManager.start();
174173
};
175174

176175
export const setCurrentSandbox: AsyncAction<Sandbox> = async (

0 commit comments

Comments
 (0)