Skip to content

Commit eae58ca

Browse files
committed
fix: resolve PR feedback
1 parent de80422 commit eae58ca

File tree

2 files changed

+3
-12
lines changed
  • packages

2 files changed

+3
-12
lines changed

packages/app/src/app/pages/Sandbox/Editor/Workspace/Chat/index.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,7 @@ export const Chat: React.FC = () => {
5656
const roomInfoUsers = state.live.roomInfo.users;
5757

5858
return (
59-
<Container
60-
ref={el => {
61-
messagesRef.current = el;
62-
}}
63-
>
59+
<Container ref={messagesRef}>
6460
<Messages>
6561
{messages.length > 0 ? (
6662
sortBy(takeRight(messages, 100), 'date').map((message, i) => {
@@ -70,9 +66,7 @@ export const Chat: React.FC = () => {
7066
metadata.color[2]
7167
})`
7268
: '#636363';
73-
const name = users.get
74-
? users.get(message.userId)
75-
: users[message.userId];
69+
const name = users[message.userId];
7670
return (
7771
<div key={message.date}>
7872
{(i === 0 || messages[i - 1].userId !== message.userId) && (

packages/common/src/types/index.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,6 @@ export type LiveUser = {
193193
avatarUrl: string;
194194
};
195195

196-
export type ChatUserGetter = (id: string) => string;
197-
198196
export type RoomInfo = {
199197
startTime: number;
200198
ownerIds: string[];
@@ -213,8 +211,7 @@ export type RoomInfo = {
213211
// We keep a separate map of user_id -> username for the case when
214212
// a user disconnects. We still need to keep track of the name.
215213
users: {
216-
[id: string]: string | ChatUserGetter;
217-
get: ChatUserGetter;
214+
[id: string]: string;
218215
};
219216
};
220217
};

0 commit comments

Comments
 (0)