Fully delete keybindingManager, since it's not doing anything anymore

Author: MichaelDeBoey

packages/app/src/app/overmind/actions.ts

@@ -90,12 +90,7 @@ export const modalOpened: Action<{
   }
 };
 
-export const modalClosed: Action = ({ state, effects }) => {
-  // We just start it whenever it closes, if already started nothing happens
-  if (state.currentModal === 'preferences') {
-    effects.keybindingManager.start();
-  }
-
+export const modalClosed: Action = ({ state }) => {
   state.currentModal = null;
 };
 

packages/app/src/app/overmind/effects/index.ts

@@ -4,7 +4,6 @@ export { default as api } from './api';
 export { default as browser } from './browser';
 export { default as connection } from './connection';
 export { default as jsZip } from './jsZip';
-export { default as keybindingManager } from './keybindingManager';
 export { default as live } from './live';
 export { default as moduleRecover } from './moduleRecover';
 export { default as notifications } from './notifications';

packages/app/src/app/overmind/effects/keybindingManager.ts

@@ -1,6 +1,6 @@
 import { Contributor, PermissionType } from '@codesandbox/common/lib/types';
 import { hasPermission } from '@codesandbox/common/lib/utils/permission';
-import { IDerive, IState, json } from 'overmind';
+import { IDerive, IState } from 'overmind';
 
 import { AsyncAction } from '.';
 
@@ -26,10 +26,6 @@ export const withLoadApp = <T>(
 
   effects.connection.addListener(actions.connectionChanged);
   actions.internal.setStoredSettings();
-  effects.keybindingManager.set(
-    json(state.preferences.settings.keybindings || []) as any
-  );
-  effects.keybindingManager.start();
   effects.codesandboxApi.listen(actions.server.onCodeSandboxAPIMessage);
 
   if (state.jwt) {

packages/app/src/app/overmind/factories.ts

@@ -170,7 +170,6 @@ export const closeModals: Action<boolean> = ({ state, effects }, isKeyDown) => {
   }
 
   state.currentModal = null;
-  effects.keybindingManager.start();
 };
 
 export const setCurrentSandbox: AsyncAction<Sandbox> = async (

packages/app/src/app/overmind/internalActions.ts

@@ -1,6 +1,6 @@
 import { Badge } from '@codesandbox/common/lib/types';
+
 import { Action, AsyncAction } from 'app/overmind';
-import { json } from 'overmind';
 
 export const viewModeChanged: Action<{
   showEditor: boolean;
@@ -23,12 +23,6 @@ export const itemIdChanged: AsyncAction<{
 }> = async ({ state, actions, effects }, { itemId }) => {
   state.preferences.itemId = itemId;
 
-  if (itemId === 'keybindings') {
-    effects.keybindingManager.pause();
-  } else {
-    effects.keybindingManager.start();
-  }
-
   if (itemId === 'integrations') {
     await actions.deployment.internal.getZeitUserDetails();
   }
@@ -128,10 +122,6 @@ export const keybindingChanged: Action<{
   );
 
   effects.settingsStore.set('keybindings', keybindingsValue);
-
-  effects.keybindingManager.set(
-    json(state.preferences.settings.keybindings) as any
-  );
 };
 
 export const zenModeToggled: Action = ({ state }) => {

packages/app/src/app/overmind/namespaces/preferences/actions.ts

@@ -19,8 +19,6 @@ export const onInitialize: OnInitialize = async (
 
   effects.flows.initialize(overmindInstance.reaction);
 
-  effects.keybindingManager.initialize();
-
   effects.api.initialize({
     provideJwtToken,
     getParsedConfigurations() {