Fix typing issues (#2831)

* Fix typing issues

* Fix more ts issues

* Fix another lint issue

* Temporarily remove typings

* Remove eslint ignores

Author: christianalfoni

.eslintrc

@@ -16,9 +16,6 @@
     "__DEV__": true,
     "Stripe": true
   },
-  "settings": {
-    "import/ignore": ["worker-loader/?", "sandbox-hooks"]
-  },
   "rules": {
     "react/jsx-filename-extension": 0,
     "react/sort-comp": 0,

packages/app/package.json

@@ -239,7 +239,6 @@
     "@types/react-dom": "^16.8.3",
     "@types/react-helmet": "^5.0.11",
     "@types/react-icons": "2.2.7",
-    "@types/react-router-dom": "^5.1.0",
     "@types/react-stripe-elements": "^1.3.2",
     "@types/resolve": "^0.0.8",
     "@types/socket.io-client": "^1.4.32",

packages/app/src/app/components/CodeEditor/index.tsx

@@ -1,23 +1,24 @@
-import React from 'react';
-import UIIcon from 'react-icons/lib/md/dvr';
-import QuestionIcon from 'react-icons/lib/go/question';
-import getUI from '@codesandbox/common/lib/templates/configuration/ui';
 import Centered from '@codesandbox/common/lib/components/flex/Centered';
 import Margin from '@codesandbox/common/lib/components/spacing/Margin';
-import isImage from '@codesandbox/common/lib/utils/is-image';
+import Tooltip from '@codesandbox/common/lib/components/Tooltip';
+import { getModulePath } from '@codesandbox/common/lib/sandbox/modules';
 import getDefinition from '@codesandbox/common/lib/templates';
+import getUI from '@codesandbox/common/lib/templates/configuration/ui';
 import { Sandbox } from '@codesandbox/common/lib/types';
-import { getModulePath } from '@codesandbox/common/lib/sandbox/modules';
-import Tooltip from '@codesandbox/common/lib/components/Tooltip';
-import { Title } from 'app/components/Title';
+import isImage from '@codesandbox/common/lib/utils/is-image';
 import { SubTitle } from 'app/components/SubTitle';
+import { Title } from 'app/components/Title';
 import Loadable from 'app/utils/Loadable';
-import { ImageViewer } from './ImageViewer';
+import React from 'react';
+import QuestionIcon from 'react-icons/lib/go/question';
+import UIIcon from 'react-icons/lib/md/dvr';
+
 import { Configuration } from './Configuration';
-import { VSCode } from './VSCode';
+import { Icon, Icons } from './elements';
+import { ImageViewer } from './ImageViewer';
 import MonacoDiff from './MonacoDiff';
 import { Props } from './types'; // eslint-disable-line
-import { Icons, Icon } from './elements';
+import { VSCode } from './VSCode';
 
 const CodeMirror = Loadable(() =>
   import(/* webpackChunkName: 'codemirror-editor' */ './CodeMirror')
@@ -164,11 +165,13 @@ export class CodeEditor extends React.PureComponent<
       );
     }
 
-    let Editor: React.ComponentClass<Props> =
-      settings.codeMirror && !props.isLive ? CodeMirror : Monaco;
+    let Editor =
+      settings.codeMirror && !props.isLive
+        ? ((CodeMirror as unknown) as React.ComponentClass<Props>)
+        : ((Monaco as unknown) as React.ComponentClass<Props>);
 
     if (settings.experimentVSCode) {
-      Editor = VSCode;
+      Editor = VSCode as React.ComponentClass<Props>;
     }
 
     return (

packages/app/src/app/pages/Dashboard/Content/CreateNewSandbox/elements.ts

@@ -32,7 +32,7 @@ export const ButtonsContainer = styled.div`
   box-sizing: border-box;
 `;
 
-export const Container = styled.div<{ hide: boolean }>`
+export const Container = styled.div<{ hide?: boolean }>`
   ${({ color, hide, theme }) => css`
     display: flex;
     justify-content: center;

packages/app/src/app/pages/Search/index.tsx

@@ -3,7 +3,7 @@ import {
   ALGOLIA_APPLICATION_ID,
   ALGOLIA_DEFAULT_INDEX,
 } from '@codesandbox/common/lib/utils/config';
-import Helmet from 'react-helmet';
+import { Helmet } from 'react-helmet';
 import MaxWidth from '@codesandbox/common/lib/components/flex/MaxWidth';
 import Margin from '@codesandbox/common/lib/components/spacing/Margin';
 import qs from 'qs';
@@ -14,7 +14,7 @@ import {
   PoweredBy,
   Configure,
 } from 'react-instantsearch/dom';
-import { History, Location} from 'history';
+import { History, Location } from 'history';
 
 import { Navigation } from 'app/pages/common/Navigation';
 import { useOvermind } from 'app/overmind';

packages/app/src/app/pages/common/ErrorBoundary/types.ts

@@ -1,6 +1,5 @@
 import React from 'react';
 import { Location } from 'history';
-import { RouteComponentProps } from 'react-router';
 
 export type ErrorInfo = {
   componentStack: string;
@@ -11,10 +10,11 @@ export interface IFallbackComponentProps {
   trace?: string;
 }
 
-export interface IErrorBoundaryProps extends RouteComponentProps {
+export interface IErrorBoundaryProps {
   children?: React.ReactNode;
   FallbackComponent?: React.ComponentType<IFallbackComponentProps>;
   onError?: (error: Error, trace: string) => void;
+  location?: Location;
 }
 
 export interface IErrorBoundaryState {

packages/app/src/sandbox/eval/presets/parcel/transpilers/html-transpiler.js

@@ -1,5 +1,5 @@
 // @flow
-
+// eslint-disable-next-line
 import HTMLWorker from 'worker-loader?publicPath=/&name=parcel-html-transpiler.[hash:8].worker.js!./html-worker';
 import type { LoaderContext } from '../../../transpiled-module';
 import WorkerTranspiler from '../../../transpilers/worker-transpiler';

packages/app/src/sandbox/eval/transpilers/babel/index.ts

@@ -1,5 +1,7 @@
+/* eslint-disable import/default */
 // @ts-ignore
 import BabelWorker from 'worker-loader?publicPath=/&name=babel-transpiler.[hash:8].worker.js!./worker/index';
+/* eslint-enable import/default */
 import { isBabel7 } from '@codesandbox/common/lib/utils/is-babel-7';
 
 import regexGetRequireStatements from './worker/simple-get-require-statements';

packages/app/src/sandbox/eval/transpilers/coffee/index.ts

@@ -1,5 +1,7 @@
+/* eslint-disable import/default */
 // @ts-ignore
 import CoffeeWorker from 'worker-loader?publicPath=/&name=coffee-transpiler.[hash:8].worker.js!./coffee-worker';
+/* eslint-enable import/default */
 
 import WorkerTranspiler from '../worker-transpiler';
 import { LoaderContext } from '../../transpiled-module';

packages/app/src/sandbox/eval/transpilers/less/index.ts

@@ -1,5 +1,7 @@
+/* eslint-disable import/default */
 // @ts-ignore
 import LessWorker from 'worker-loader?publicPath=/&name=less-transpiler.[hash:8].worker.js!./less-worker';
+/* eslint-enable import/default */
 
 import WorkerTranspiler from '../worker-transpiler';
 import { LoaderContext } from '../../transpiled-module';