Quickfix context menu options that shouldn't be available

Author: CompuIves

packages/app/src/app/overmind/actions.ts

@@ -62,7 +62,7 @@ export const notificationRemoved: Action<{
 }> = ({ state }, { id }) => {
   const { notifications } = state;
   const notificationToRemoveIndex = notifications.findIndex(
-    notification => notification.id === id
+    (notification) => notification.id === id
   );
 
   state.notifications.splice(notificationToRemoveIndex, 1);
@@ -151,7 +151,7 @@ export const addNotification: Action<{
 
 export const removeNotification: Action<number> = ({ state }, id) => {
   const notificationToRemoveIndex = state.notifications.findIndex(
-    notification => notification.id === id
+    (notification) => notification.id === id
   );
 
   state.notifications.splice(notificationToRemoveIndex, 1);

packages/app/src/app/pages/Dashboard/Components/Selection/ContextMenus/SandboxMenu.tsx

@@ -41,10 +41,16 @@ export const SandboxMenu: React.FC<SandboxMenuProps> = ({
   const label = isTemplate ? 'Template' : 'Sandbox';
   const isPro = user && Boolean(user.subscription);
 
+  const hasAccess = React.useMemo(() => item.sandbox.teamId === activeTeam, [
+    item,
+    activeTeam,
+  ]);
+
   const isOwner = React.useMemo(() => {
     if (item.type !== 'template') {
-      return true;
+      return item.sandbox.teamId === activeTeam;
     }
+
     return (
       item.sandbox.author && item.sandbox.author.username === user.username
     );
@@ -78,6 +84,7 @@ export const SandboxMenu: React.FC<SandboxMenuProps> = ({
       </Menu.ContextMenu>
     );
   }
+  // TODO(@CompuIves): refactor this to an array
 
   return (
     <Menu.ContextMenu
@@ -158,7 +165,7 @@ export const SandboxMenu: React.FC<SandboxMenuProps> = ({
         </MenuItem>
       )}
 
-      {isPro ? (
+      {hasAccess && activeWorkspaceAuthorization !== 'READ' && isPro ? (
         <>
           <Menu.Divider />
           {sandbox.privacy !== 0 && (
@@ -200,8 +207,11 @@ export const SandboxMenu: React.FC<SandboxMenuProps> = ({
         </>
       ) : null}
       <Menu.Divider />
-      <MenuItem onSelect={() => setRenaming(true)}>Rename {label}</MenuItem>
-      {activeWorkspaceAuthorization !== 'READ' &&
+      {hasAccess && activeWorkspaceAuthorization !== 'READ' && (
+        <MenuItem onSelect={() => setRenaming(true)}>Rename {label}</MenuItem>
+      )}
+      {hasAccess &&
+        activeWorkspaceAuthorization !== 'READ' &&
         !isTemplate &&
         (sandbox.isFrozen ? (
           <MenuItem
@@ -226,53 +236,56 @@ export const SandboxMenu: React.FC<SandboxMenuProps> = ({
             Freeze {label}
           </MenuItem>
         ))}
-      {isTemplate ? (
-        <MenuItem
-          onSelect={() => {
-            actions.dashboard.unmakeTemplates({
-              templateIds: [sandbox.id],
-            });
-          }}
-        >
-          Convert to Sandbox
-        </MenuItem>
-      ) : (
-        <MenuItem
-          onSelect={() => {
-            actions.dashboard.makeTemplates({
-              sandboxIds: [sandbox.id],
-            });
-          }}
-        >
-          Make Sandbox a Template
-        </MenuItem>
-      )}
+      {hasAccess &&
+        (isTemplate ? (
+          <MenuItem
+            onSelect={() => {
+              actions.dashboard.unmakeTemplates({
+                templateIds: [sandbox.id],
+              });
+            }}
+          >
+            Convert to Sandbox
+          </MenuItem>
+        ) : (
+          <MenuItem
+            onSelect={() => {
+              actions.dashboard.makeTemplates({
+                sandboxIds: [sandbox.id],
+              });
+            }}
+          >
+            Make Sandbox a Template
+          </MenuItem>
+        ))}
       <Menu.Divider />
-      {isTemplate ? (
-        <MenuItem
-          onSelect={() => {
-            const template = item as DashboardTemplate;
-            actions.dashboard.deleteTemplate({
-              sandboxId: template.sandbox.id,
-              templateId: template.template.id,
-            });
-            setVisibility(false);
-          }}
-        >
-          Delete Template
-        </MenuItem>
-      ) : (
-        <MenuItem
-          onSelect={() => {
-            actions.dashboard.deleteSandbox({
-              ids: [sandbox.id],
-            });
-            setVisibility(false);
-          }}
-        >
-          Delete Sandbox
-        </MenuItem>
-      )}
+      {hasAccess &&
+        activeWorkspaceAuthorization !== 'READ' &&
+        (isTemplate ? (
+          <MenuItem
+            onSelect={() => {
+              const template = item as DashboardTemplate;
+              actions.dashboard.deleteTemplate({
+                sandboxId: template.sandbox.id,
+                templateId: template.template.id,
+              });
+              setVisibility(false);
+            }}
+          >
+            Delete Template
+          </MenuItem>
+        ) : (
+          <MenuItem
+            onSelect={() => {
+              actions.dashboard.deleteSandbox({
+                ids: [sandbox.id],
+              });
+              setVisibility(false);
+            }}
+          >
+            Delete Sandbox
+          </MenuItem>
+        ))}
     </Menu.ContextMenu>
   );
 };