Chore: Add react-router-dom typing (#2869)

* Add @types/react-router-dom to app repo

* fix known typing errors for missing RouteComponentProps for withRouter component

Author: br1anchen

packages/app/package.json

@@ -239,6 +239,7 @@
     "@types/react-dom": "^16.8.3",
     "@types/react-helmet": "^5.0.11",
     "@types/react-icons": "2.2.7",
+    "@types/react-router-dom": "^4.3.1",
     "@types/react-stripe-elements": "^1.3.2",
     "@types/resolve": "^0.0.8",
     "@types/socket.io-client": "^1.4.32",

packages/app/src/app/pages/Dashboard/Sidebar/TemplateItem/TemplateItem.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import { DropTarget } from 'react-dnd';
-import { withRouter } from 'react-router-dom';
+import { withRouter, RouteComponentProps } from 'react-router-dom';
 // @ts-ignore
 import TemplateIcon from '-!svg-react-loader!@codesandbox/common/lib/icons/template.svg';
 import { Item } from '../Item';
@@ -14,13 +14,9 @@ interface ITemplateItemProps {
   connectDropTarget?: any;
 }
 
-const TemplateItemComponent: React.FC<ITemplateItemProps> = ({
-  currentPath,
-  isOver,
-  canDrop,
-  connectDropTarget,
-  teamId,
-}: ITemplateItemProps) => {
+const TemplateItemComponent: React.FC<
+  ITemplateItemProps & RouteComponentProps
+> = ({ currentPath, isOver, canDrop, connectDropTarget, teamId }) => {
   const url = teamId
     ? `/dashboard/teams/${teamId}/templates`
     : `/dashboard/templates`;

packages/app/src/app/pages/common/ErrorBoundary/ErrorBoundary.tsx

@@ -1,9 +1,10 @@
 import React, { Component } from 'react';
+import { RouteComponentProps } from 'react-router-dom';
 import { CodeSadbox } from './CodeSadbox';
 import { IErrorBoundaryProps, ErrorInfo, IErrorBoundaryState } from './types';
 
 export class ErrorBoundary extends Component<
-  IErrorBoundaryProps,
+  RouteComponentProps & IErrorBoundaryProps,
   IErrorBoundaryState
 > {
   static getDerivedStateFromError(error: Error) {

yarn.lock

@@ -4127,6 +4127,23 @@
     "@types/prop-types" "*"
     "@types/react" "*"
 
+"@types/react-router-dom@^4.3.1":
+  version "4.3.5"
+  resolved "https://registry.yarnpkg.com/@types/react-router-dom/-/react-router-dom-4.3.5.tgz#72f229967690c890d00f96e6b85e9ee5780db31f"
+  integrity sha512-eFajSUASYbPHg2BDM1G8Btx+YqGgvROPIg6sBhl3O4kbDdYXdFdfrgQFf/pcBuQVObjfT9AL/dd15jilR5DIEA==
+  dependencies:
+    "@types/history" "*"
+    "@types/react" "*"
+    "@types/react-router" "*"
+
+"@types/react-router@*":
+  version "5.1.2"
+  resolved "https://registry.yarnpkg.com/@types/react-router/-/react-router-5.1.2.tgz#41e5e6aa333a7b9a2bfdac753c04e1ca4b3e0d21"
+  integrity sha512-euC3SiwDg3NcjFdNmFL8uVuAFTpZJm0WMFUw+4eXMUnxa7M9RGFEG0szt0z+/Zgk4G2k9JBFhaEnY64RBiFmuw==
+  dependencies:
+    "@types/history" "*"
+    "@types/react" "*"
+
 "@types/react-stripe-elements@^1.3.2":
   version "1.3.2"
   resolved "https://registry.yarnpkg.com/@types/react-stripe-elements/-/react-stripe-elements-1.3.2.tgz#02ed6802b16366b4ebc6b85b8bd3e8befa553b79"
@@ -8069,7 +8086,7 @@ console-control-strings@^1.0.0, console-control-strings@~1.1.0:
   integrity sha1-PXz0Rk22RG6mRL9LOVB/mFEAjo4=
 
 console-feed@CompuIves/console-feed#build2, console-feed@^2.8.5:
-  version "2.8.8"
+  version "2.8.9"
   resolved "https://codeload.github.com/CompuIves/console-feed/tar.gz/42f10eb3063f0f26ee9745c4c9e4542cb5591f46"
   dependencies:
     emotion "^9.1.1"