-
Notifications
You must be signed in to change notification settings - Fork 143
chore: add multiple db platforms in GA workflow PHPUnit #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I was wrong. Tests failed on MySQL. https://github.com/codeigniter4/shield/runs/7625886471?check_suite_focus=true |
|
The first one is an easy fix: The other one... this is always an issue. Because we technically support |
MGatner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual PR code looks good though and seems to have worked well!
237e731 to
cb31980
Compare
|
PHP 7.4 - Postgre |
|
PHP 8.0 - OCI8 |
091c5a7 to
3b93d2d
Compare
3b93d2d to
b5a7322
Compare
|
All green, |
It is better to have it. |
Probably now Shield works with only
MySQL orSQLite3.