fix: Bootstrap column on mobile #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
approved these changes
Jul 6, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
The number of times this layout structure is repeated makes me think we probably need to change our view hierarchies. Beyond the scope of this PR though - thanks for the fix!
Contributor
Author
|
Hi @MGatner and thank you for the approval Indeed, I also think that it is possible to reduce this duplicated code, but I don't know what would be the best way to do it In the "layout.php" file maybe? |
Member
|
Before: After: |
kenjis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271