Bug: [CI 4.5.0] Time object when savin date (login, user, etc) with MySQLI driver

[nicojmb]

PHP Version

8.1

CodeIgniter4 Version

4.5.0

Shield Version

1.0.2

Which operating systems have you tested for this bug?

Linux

Which server did you use?

apache

Database

MariaDB 10.5.24

Did you customize Shield?

No

What happened?

In CI 4.5.0 it's forbidden pass an object to save value in MYSQL driver, the value must be a string, located in:

• UserIdentityModel --> Line 445
• TokenLoginModel --> Line 38
• RememberModel -->Line 47 & Line 62
• LoginModel --> Line 83 & Line 124

*** I think that is more easy fix in CI4 4.5.0 directly adding (string) before value.

Steps to Reproduce

Install CI 4.5.0 and login

Expected Output

Correct login

Anything else?

No response

[kenjis]

In CI 4.5.0 it's forbidden pass an object to save value in MYSQL driver, the value must be a string

Why?

[datamweb]

Why?

https://github.com/codeigniter4/CodeIgniter4/blob/457890659c6ed18488a89c14d642f28060d31101/system/Database/BaseConnection.php#L1384-L1391

https://github.com/codeigniter4/CodeIgniter4/blob/457890659c6ed18488a89c14d642f28060d31101/system/Database/MySQLi/Connection.php#L342-L352

[kenjis]

Hmmm, I didn't notice but there are many flows that the data passed to Model is not handled by timeToString().

The tests for #1027 passed just because CI did not use strict types.

[GeneralFutz]

I have similar issues after fix from #1087. Many places where Time::now() is being called and returning the object. Places that might have been Time::now()->format(Y-m-d H:m:s) in earlier versions . Temporary fix in those places seems to be getting to successful logins and registration.

[kenjis]

I sent:

• fix: TypeError when Time is passed to Model CodeIgniter4#8738
• fix: passing Time to Query Builder in UserModel #1095

[kenjis]

Upgrade to CI v4.5.1 and Shield v1.0.3.