Skip to content

Conversation

@paulbalandan
Copy link
Member

Description
Supersedes and closes #8878

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan
Copy link
Member Author

@samsonasik It seems the AssertRegExpRector is giving a wrong transformation of a preg_match assertion if the $matches variable is used in a subsequent assert.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/9449485549/job/26025852003?pr=8952

@samsonasik
Copy link
Member

@paulbalandan could you reproduce at https://getrector.com/demo and report at https://github.com/rectorphp/rector/issues ? Thank you.

@paulbalandan
Copy link
Member Author

@samsonasik see rectorphp/rector#8669

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 12, 2024
@kenjis kenjis merged commit b6c668c into codeigniter4:develop Jun 14, 2024
@paulbalandan paulbalandan deleted the redis-delete-matching-prefix branch June 14, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants