From 53f82f371126b196a78d272c7de2f7e1302f1e18 Mon Sep 17 00:00:00 2001 From: kenjis Date: Fri, 16 Feb 2024 13:12:34 +0900 Subject: [PATCH] docs: replace $this->validate() with validateData() validate() is not recommended. --- .../source/installation/upgrade_file_upload/001.php | 2 +- user_guide_src/source/installation/upgrade_validations.rst | 5 +++-- .../source/installation/upgrade_validations/001.php | 2 +- .../source/installation/upgrade_validations/002.php | 6 ++++-- user_guide_src/source/libraries/validation.rst | 2 +- user_guide_src/source/libraries/validation/045.php | 2 +- 6 files changed, 11 insertions(+), 8 deletions(-) diff --git a/user_guide_src/source/installation/upgrade_file_upload/001.php b/user_guide_src/source/installation/upgrade_file_upload/001.php index c4c6d50db7b4..ca2c85372ca2 100644 --- a/user_guide_src/source/installation/upgrade_file_upload/001.php +++ b/user_guide_src/source/installation/upgrade_file_upload/001.php @@ -11,7 +11,7 @@ public function index() public function do_upload() { - $this->validate([ + $this->validateData([], [ 'userfile' => [ 'uploaded[userfile]', 'max_size[userfile,100]', diff --git a/user_guide_src/source/installation/upgrade_validations.rst b/user_guide_src/source/installation/upgrade_validations.rst index 8343b989a699..7f42cf8e1f70 100644 --- a/user_guide_src/source/installation/upgrade_validations.rst +++ b/user_guide_src/source/installation/upgrade_validations.rst @@ -32,9 +32,10 @@ Upgrade Guide 2. Within the controller you have to change the following: - - ``$this->load->helper(array('form', 'url'));`` to ``helper(['form', 'url']);`` + - ``$this->load->helper(array('form', 'url'));`` to ``helper('form');`` - remove the line ``$this->load->library('form_validation');`` - - ``if ($this->form_validation->run() == FALSE)`` to ``if (! $this->validate([]))`` + - ``if ($this->form_validation->run() == FALSE)`` to ``if (! $this->validateData($data, $rules))`` + where ``$data`` is the data to validate, typically, the POST data ``$this->request->getPost()``. - ``$this->load->view('myform');`` to ``return view('myform', ['validation' => $this->validator,]);`` 3. You have to change the validation rules. The new syntax is to set the rules as array in the controller: diff --git a/user_guide_src/source/installation/upgrade_validations/001.php b/user_guide_src/source/installation/upgrade_validations/001.php index 36ec03941532..0ba9b034708f 100644 --- a/user_guide_src/source/installation/upgrade_validations/001.php +++ b/user_guide_src/source/installation/upgrade_validations/001.php @@ -1,6 +1,6 @@ validate([ +$isValid = $this->validateData($data, [ 'name' => 'required|min_length[3]', 'email' => 'required|valid_email', 'phone' => 'required|numeric|max_length[10]', diff --git a/user_guide_src/source/installation/upgrade_validations/002.php b/user_guide_src/source/installation/upgrade_validations/002.php index 38e81eb202d9..b3cd4f9db13d 100644 --- a/user_guide_src/source/installation/upgrade_validations/002.php +++ b/user_guide_src/source/installation/upgrade_validations/002.php @@ -8,9 +8,11 @@ class Form extends Controller { public function index() { - helper(['form', 'url']); + helper('form'); - if (! $this->validate([ + $data = $this->request->getPost(); + + if (! $this->validateData($data, [ // Validation rules ])) { return view('myform'); diff --git a/user_guide_src/source/libraries/validation.rst b/user_guide_src/source/libraries/validation.rst index 710cd4965dd8..c7c8449562a5 100644 --- a/user_guide_src/source/libraries/validation.rst +++ b/user_guide_src/source/libraries/validation.rst @@ -998,7 +998,7 @@ file upload related rules:: // In the controller - $this->validate([ + $this->validateData([], [ 'avatar' => 'uploaded[avatar]|max_size[avatar,1024]', ]); diff --git a/user_guide_src/source/libraries/validation/045.php b/user_guide_src/source/libraries/validation/045.php index 1becb578dc21..401897f0e927 100644 --- a/user_guide_src/source/libraries/validation/045.php +++ b/user_guide_src/source/libraries/validation/045.php @@ -2,7 +2,7 @@ // In Controller. -if (! $this->validate([ +if (! $this->validateData($data, [ 'username' => 'required', 'password' => 'required|min_length[10]', ])) {