refactor: upgrade to PHP 8.1 with rector

[kenjis]

Important

All refactoring will be performed just prior to the release of v4.5.0.

Description
Supersedes #7964
Closes #6921

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[ddevsr]

@kenjis I suggest rules ChangeSwitchToMatchRector by Rector\Php80\Rector\Switch_\ChangeSwitchToMatchRector

[kenjis]

Doesn't it included in LevelSetList::UP_TO_PHP_81?

[ddevsr]

Doesn't it included in LevelSetList::UP_TO_PHP_81?

Sorry i didnt read it

[kenjis]

@samsonasik When rector is executed on this branch, rector enters an infinite loop, because of the following files:

            __DIR__ . '/system/Common.php',
            __DIR__ . '/system/Helpers/filesystem_helper.php',
            __DIR__ . '/system/Helpers/text_helper.php',
            __DIR__ . '/system/Helpers/form_helper.php',
            __DIR__ . '/system/Helpers/html_helper.php',
            __DIR__ . '/system/Helpers/number_helper.php',

Rector adds too many declare(strict_types=1); lines to them.
Is this a bug?

[samsonasik]

@kenjis probably, could you create a reproducible at https://getrector.com/demo and report at https://github.com/rectorphp/rector/ ? Thank you.

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[kenjis]

@samsonasik These files with too many declare(strict_types=1) are all functions, not class files.
But I cannot make a simple reproducible sample code.

[samsonasik]

@kenjis the DeclareStrictTypesRector can be skipped if it make too many changes, and create separate PR to enable that?

[samsonasik]

Actually, the DeclareStrictTypesRector is not part of any set list now, so should not apply the changes except registered, I can't see any addition of declare(strict_types=1) now in github diff

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[github-actions]

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

[samsonasik]

@kenjis could you rebase and retry add DeclareStrictTypesRector, run composer update, and verify if no longer infinite loop on latest rector 1.0.3? Thank you.

[kenjis]

@samsonasik Thank you! It worked fine.

[OK] 148 files have been changed by Rector  

Dropped 1ecb049