Skip to content

docs: fix Database Utility Class getXMLFromResult() #8276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2023
Merged

docs: fix Database Utility Class getXMLFromResult() #8276

merged 3 commits into from
Nov 30, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Nov 30, 2023

Description

  • fix getXMLFromResult() description
  • add "Initializing the Utility Class"

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Nov 30, 2023
@kenjis kenjis mentioned this pull request Nov 30, 2023
Merged
3 tasks
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 30, 2023
datamweb
datamweb reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utility Class also supports generate as CSV, but it is not documented.

@kenjis
Copy link
Member Author

kenjis commented Nov 30, 2023

See #8277

paulbalandan
paulbalandan reviewed Nov 30, 2023
View reviewed changes
@kenjis kenjis merged commit c5cb69e into codeigniter4:develop Nov 30, 2023
@kenjis kenjis deleted the fix-docs-db-utils branch November 30, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@datamweb datamweb datamweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @paulbalandan