Skip to content

test: FactoriesTest fails in develop after v4.4.2 #8096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

test: FactoriesTest fails in develop after v4.4.2 #8096

wants to merge 2 commits into from

Conversation

@ping-yee
Copy link
Contributor

@ping-yee ping-yee commented Oct 26, 2023

Description
See #8094.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ping-yee
test: add the tearDown to reset the mock service after run `testRedoi…
62fe2ed 
…ngDiscoveryWillStillSetDidDiscoveryPropertyToTrue()` test.
samsonasik
samsonasik reviewed Oct 26, 2023
View reviewed changes
@kenjis kenjis added the duplicate Issue or pull request duplicates an already existing issue/pull request label Oct 26, 2023
@kenjis
Copy link
Member

kenjis commented Oct 26, 2023

Duplicate of #8095

@kenjis kenjis marked this as a duplicate of #8095 Oct 26, 2023
@ping-yee ping-yee closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees

No one assigned

Labels

duplicate Issue or pull request duplicates an already existing issue/pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ping-yee @kenjis @samsonasik