Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 27, 2023

Description
See codeigniter4/shield#802

1) Tests\Authentication\Filters\PermissionFilterTest::testFilterNotAuthorized
Test code or tested code did not (only) close its own output buffers

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.4 labels Aug 27, 2023
@kenjis kenjis mentioned this pull request Aug 29, 2023
9 tasks
@kenjis kenjis merged commit 5d40f69 into codeigniter4:develop Sep 4, 2023
@kenjis kenjis deleted the fix-feature-test-buffering branch September 4, 2023 02:29
@kenjis
Copy link
Member Author

kenjis commented Sep 4, 2023

@datamweb Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants