Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 18, 2023

Description
See https://forum.codeigniter.com/showthread.php?tid=87335&pid=411906#pid411906

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added documentation Pull requests for documentation only 4.4 labels Aug 18, 2023
@kenjis kenjis changed the title docs: improve description for Factories BC [4.4] docs: improve description for Factories BC Aug 18, 2023
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change to "with namespace". Some readability suggestions.

@kenjis
Copy link
Member Author

kenjis commented Aug 21, 2023

Updated!
Screenshot from 2023-08-21 10-02-37

@kenjis kenjis requested a review from MGatner August 21, 2023 01:03
@kenjis kenjis mentioned this pull request Aug 22, 2023
22 tasks
@kenjis kenjis merged commit c0029f9 into codeigniter4:4.4 Aug 23, 2023
@kenjis kenjis deleted the fix-docs-changelog-4.4-factories branch August 23, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants