Skip to content

fix: instances of Validation rules are incremented each time run() is executed #7815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2023
Merged

fix: instances of Validation rules are incremented each time run() is executed #7815

merged 2 commits into from
Aug 17, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 14, 2023

Description
Instances of Validation rules are incremented each time run() is executed.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 14, 2023
@kenjis kenjis mentioned this pull request Aug 14, 2023
Closed
22 tasks
@kenjis kenjis merged commit 2d6eb27 into codeigniter4:develop Aug 17, 2023
@kenjis kenjis deleted the fix-validation-rule-instances branch August 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @paulbalandan