chore(deps-dev): update rector/rector requirement from 0.17.0 to 0.17.1 #7578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@0.17.0...0.17.1) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Member
|
I updated rector config and re-run rector |
kenjis
reviewed
Jun 14, 2023
kenjis
reviewed
Jun 15, 2023
| $builder = new BaseBuilder('users', $this->db); | ||
|
|
||
| $sql = 'REGEXP_SUBSTR(ral_anno,"[0-9]{1,2}([,.][0-9]{1,3})([,.][0-9]{1,3})") AS ral'; | ||
| $sql = 'REGEXP_SUBSTR(ral_anno,"\d{1,2}([,.]\d{1,3})([,.]\d{1,3})") AS ral'; |
Member
There was a problem hiding this comment.
Why does rector change this line? This is just a string.
Or if \d in REGEXP_SUBSTR (Oracle/MySQL8 function) matches unicode number characters like ६, this is a breaking change.
Member
There was a problem hiding this comment.
Ok, I will remove the rule from the list.
Member
There was a problem hiding this comment.
It seems rector just replaces string [0-9].
I created an issue: rectorphp/rector#7993
Member
|
@kenjis I skipped |
paulbalandan
approved these changes
Jun 15, 2023
kenjis
approved these changes
Jun 15, 2023
Member
|
@kenjis @paulbalandan Thank you for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
... (truncated)
Commits
11401dcRector 0.17.1f4f965bUpdated Rector to commit dac6b46cdbd4a7820d923af040d1f8627faced393c126cfUpdated Rector to commit e11e77f6c345558fa8f6593a26c2a3c012b8d581cc9d836Updated Rector to commit 72f772294bc816daa7cba09fb512306fffda2ee34c28e35Updated Rector to commit 20ec11e73d8998f9ad7533c8f179ee7be8e2abdf50725c3Updated Rector to commit 255161870edc4a8bd94630863256caae38ca3bcd1b592b0Updated Rector to commit c6acfe8108cfbabb7064ac6c4e1acba544b2b3b073448ffUpdated Rector to commit 883608be8a7fcade8b0cc78d74b26f17b690c189594af98Updated Rector to commit 5431047ba10053a1204866e9d33b3061f39a1b7d5712e3dUpdated Rector to commit b4eb417407360b419e71eaa7609209a1597441e2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)