Skip to content

refactor: Entity variable #7499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2023
Merged

refactor: Entity variable #7499

merged 3 commits into from
May 19, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented May 14, 2023

Description
Reassignment makes the code difficult to understand.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label May 14, 2023
@kenjis kenjis merged commit 735b823 into codeigniter4:develop May 19, 2023
@kenjis kenjis deleted the refactor-Entity-variable branch May 19, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @paulbalandan