-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: standardize behavior of make:cell and Cells
#7481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c52c94a to
618f631
Compare
|
This behavior does not match the current specification in the docs.
In my understanding, the current specification is:
There is inconsistency between |
|
Based on @lonnieezell 's comment, the specification should be:
That part of the docs should be updated, too. |
|
If we change the specification, add the following in this PR:
Also, it would be nice to have an option to generate |
618f631 to
f5ade58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the exception of the one item below this looks good to me.
f5ade58 to
6f05243
Compare
02a4166 to
5371935
Compare
5371935 to
81f280f
Compare
|
@paulbalandan Thank you! |
Description
Fixes #7472
Fixes #7469
Supersedes and closes #7479
Supersedes and closes #7471
Checklist: