Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Apr 26, 2023

Description
Closes #7453

  • improve description on Env Vars and Config values
  • add example to set database.default.encrypt with .env

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Apr 26, 2023
@kenjis
Copy link
Member Author

kenjis commented Apr 26, 2023

I have never had a case where the array value needed to be set in an environment variable, but it seems to me that the only way to set SSL settings in MySQL is to set the array in an environment variable.

Therefore, I have added an example of how to set it.

Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting description! This explanation will be useful for everyone.

Shouldn't these descriptions be added in the Environment Variables section or related env sections?

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not thrilled about having a hack in our user guide but it is actually a handy tip.

@kenjis kenjis merged commit a43018a into codeigniter4:develop Apr 26, 2023
@kenjis kenjis deleted the docs-improve-env-var-and-config branch April 26, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: MySQLi Config "encrypt" values not being respected

3 participants