Skip to content

refactor: remove Workaround for Faker deprecation errors in PHP 8.2 #6987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2022
Merged

refactor: remove Workaround for Faker deprecation errors in PHP 8.2 #6987

merged 1 commit into from
Dec 17, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Dec 17, 2022 •
edited
Loading

Description
See #6758
See https://github.com/FakerPHP/Faker/releases/tag/v1.21.0

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.3 refactor Pull requests that refactor code labels Dec 17, 2022
@samsonasik samsonasik merged commit a68891a into codeigniter4:4.3 Dec 17, 2022
@samsonasik
Copy link
Member

samsonasik commented Dec 17, 2022

Thank you @kenjis

@kenjis kenjis deleted the remove-isFakerDeprecationError branch December 17, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @samsonasik