Skip to content

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Nov 1, 2022

Description
"Successful" run: https://github.com/paulbalandan/CodeIgniter4/actions/runs/3369749982/jobs/5589787478

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Nov 1, 2022
@paulbalandan paulbalandan force-pushed the check-version branch 2 times, most recently from 6c01dc8 to 446d3f7 Compare November 1, 2022 10:54
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought this up on the release thread in response to a contributor comment, but we need to decide what a "hotfix" looks like. This seems to be a vote for "go back through the entire release process" so that our version numbers are always consistent. I think that is probably the best approach, since we're not actually pushing anything to "production" to begin with. Alternatives would be to release sub-versions like 4.2.8.1 or 4.2.8-hotfix, or to delete tags from all distributable repos and redo the release.

@paulbalandan paulbalandan marked this pull request as draft November 1, 2022 11:05
@kenjis
Copy link
Member

kenjis commented Nov 1, 2022

If we are going to follow Semantic Versioning, I think we cannot use 4.2.8.1 or 4.2.8-hotfix.
Also, we cannot remove the tags.
Am I wrong?

@paulbalandan paulbalandan force-pushed the check-version branch 6 times, most recently from 3db1397 to 460b8a4 Compare November 1, 2022 13:25
@paulbalandan paulbalandan marked this pull request as ready for review November 1, 2022 13:38
@paulbalandan
Copy link
Member Author

I think redoing the release is the best approach, but I'm not sure if the new tag's SHA will be picked up by packagist.

@MGatner
Copy link
Member

MGatner commented Nov 2, 2022

Packagist will update if you remove a tag and re-release it. This is my approach on small libraries when I make a mistake. We could do that here as well, just have to delete the tags from the distributable repos too.

Sticking with SemVer is best. It looks like we could append "build metadata" like v4.0.8+hotfix.1 but that seems more of a hack than a supported approach. So let's go with new release or removing tags.

@kenjis
Copy link
Member

kenjis commented Nov 2, 2022

When we use this PR,
if we forget to update the version number, the framework deploy will stop.
But in this repository the release was done already?

@paulbalandan
Copy link
Member Author

... But in this repository the release was done already?

Yes, because the release payload from this repo will be used in creating the respective releases in the 3 repos through actions/github-script

@MGatner
Copy link
Member

MGatner commented Nov 3, 2022

I think that's fine. Deleting tags isn't as big a deal as it seems, and if the Action stops it from happening on the distributables then we are pretty much guaranteed nobody has been affected.

@kenjis
Copy link
Member

kenjis commented Nov 3, 2022

Yes, this repository is not a Composer package.
Removing tags/releases is not a big deal if we do it quickly.

@paulbalandan paulbalandan merged commit 30fd482 into codeigniter4:develop Nov 4, 2022
@paulbalandan paulbalandan deleted the check-version branch November 4, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants