-
Notifications
You must be signed in to change notification settings - Fork 2k
Add a check for updated version before deployment #6802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c01dc8 to
446d3f7
Compare
MGatner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I brought this up on the release thread in response to a contributor comment, but we need to decide what a "hotfix" looks like. This seems to be a vote for "go back through the entire release process" so that our version numbers are always consistent. I think that is probably the best approach, since we're not actually pushing anything to "production" to begin with. Alternatives would be to release sub-versions like 4.2.8.1 or 4.2.8-hotfix, or to delete tags from all distributable repos and redo the release.
|
If we are going to follow Semantic Versioning, I think we cannot use 4.2.8.1 or 4.2.8-hotfix. |
3db1397 to
460b8a4
Compare
460b8a4 to
ebf7e66
Compare
|
I think redoing the release is the best approach, but I'm not sure if the new tag's SHA will be picked up by packagist. |
|
Packagist will update if you remove a tag and re-release it. This is my approach on small libraries when I make a mistake. We could do that here as well, just have to delete the tags from the distributable repos too. Sticking with SemVer is best. It looks like we could append "build metadata" like |
|
When we use this PR, |
Yes, because the release payload from this repo will be used in creating the respective releases in the 3 repos through |
|
I think that's fine. Deleting tags isn't as big a deal as it seems, and if the Action stops it from happening on the distributables then we are pretty much guaranteed nobody has been affected. |
|
Yes, this repository is not a Composer package. |
Description
"Successful" run: https://github.com/paulbalandan/CodeIgniter4/actions/runs/3369749982/jobs/5589787478
Checklist: