Skip to content

Remove testing of deprecated methods in CookieStore #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

Remove testing of deprecated methods in CookieStore #6781

merged 1 commit into from
Oct 28, 2022

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Oct 28, 2022

Description
Found in #6773
Since the deprecated methods have @codeCoverageIgnore already, no testing is needed to cover those methods.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Oct 28, 2022
@samsonasik
Copy link
Member

samsonasik commented Oct 28, 2022

Thank you @paulbalandan

@samsonasik samsonasik merged commit caa3c95 into codeigniter4:develop Oct 28, 2022
@paulbalandan paulbalandan deleted the deprecated-mocked-method branch October 29, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan @samsonasik