Skip to content

Conversation

@sba
Copy link
Contributor

@sba sba commented Jul 6, 2022

replaces #6197

With this pull request the error message in the file app/Views/errors/html/production.php can be translated.

Translation for error_404.php and error_exception.php will follow with a other PR

@sba
Copy link
Contributor Author

sba commented Jul 6, 2022

@kenjis once again with a new, cleaner PR!

Copy link
Contributor

@totoprayogo1916 totoprayogo1916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is "system/Language/en/Errors.php" the same as "app/Views/errors/html/production.php"?

@sba
Copy link
Contributor Author

sba commented Jul 6, 2022

Why is "system/Language/en/Errors.php" the same as "app/Views/errors/html/production.php"?

ahh, crap! Copy/paste error - will fix it!

pasted the the right content!
sba added 2 commits July 6, 2022 12:15
fix indentation
remove obsolete type="text/css" attribute
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you.

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.3 labels Jul 8, 2022
@MGatner MGatner merged commit da5470e into codeigniter4:4.3 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants