Bug: [Pager] Knocks down variables for View

[neznaika0]

PHP Version

8.2

CodeIgniter4 Version

4.3.6

CodeIgniter4 Installation Method

Composer (using codeigniter4/appstarter)

Which operating systems have you tested for this bug?

Linux

Which server did you use?

cli-server (PHP built-in webserver)

Database

No response

What happened?

I couldn't determine exactly why it works in one place and not in another. When calling $pager->links(), my parameters set inside the template disappear. I added a "title", but it disappears after the Pager. If you install it in the controller, everything is fine. BUT elsewhere, setting variables in the template works fine (even with Pager)

Steps to Reproduce

<?php
// init $model->paginate() in Controller
$this->setVar('title', 'New title');

echo $this->extend('_layout/backend');
?>

<?= $this->section('content') ?>
    <table class="table text-center">
        ...
    </table>
    <?php dd($this, 'first') ?>

    <?= $pager->links('default'); ?>

    <?php dd($this, 'second') ?>
<?= $this->endSection() ?>

In first dump N variables, in second N-1 vars (unset "title")

Expected Output

I looked into the system Pager file. It calls $this->view->setVar('pager', $pager)->render(...) Probably this call interrupts the previous template code?

Anything else?

No response

[kenjis]

Ref #6251

[kenjis]

@neznaika0 Thank you for reporting.

But what is the exact issue?
Your code does not make sense. Why do you need title after $pager->links('default').
Also your sample code is not executable.
It would be nice that you provide the minimum working code that reproduce your issue.
I mean, just copy and paste, and it reproduces this issue.

[neznaika0]

yes, the code is shown for general understanding so uses the model. The main problem is that $title disappears in the final rendering (backend template, <title>$title</title>). And this is only when Pager is called, without it (Pager) $title exists and is added in the extensible template.
Yes, right now $title is not needed in the template, it should be in the final HTML
The reason for this use is to transfer - the setting of variables inside the template instead of the controller
I am far from the PC, if possible I will post a demo

[kenjis]

The View is very complicated system, and I don't get it in details.
I don't get the difference among $data, $tempData, $renderVars, and $saveData yet.

But it seems $this->tempData is the variables that can be used in the view files:

CodeIgniter4/system/View/View.php

Lines 218 to 230 in f8bdf2c

	// Save current vars
	$renderVars = $this->renderVars;
	$output = (function (): string {
	extract($this->tempData);
	ob_start();
	include $this->renderVars['file'];
	return ob_get_clean() ?: '';
	})();
	// Get back current vars
	$this->renderVars = $renderVars;

And if we call the render(), it resets $this->tempData:

CodeIgniter4/system/View/View.php

Line 280 in f8bdf2c

$this->tempData = null;

[kenjis]

The main problem is that $title disappears in the final rendering (backend template, <title>$title</title>).

It seems wrong that the Pager uses the shared View object.
$pager->links() calls View::render() that resets $this->tempData.

[neznaika0]

Yes, I looked a little. There are general data (from the controller or passed to render()), there are additional ones in the template.
I think this is the wrong behavior of Pager. It should not interrupt the flow of templates.
do you have any suggestions?

[neznaika0]

Will cloning View or \Config\Services::renderer(getShared:false) fix the situation?

[kenjis]

Yes, probably. Please try: #7758

[neznaika0]

kenjis, great. Fixed problem. I hope this will not affect in the future

[melroy89]

After my upgrade I got issues.

I actually used two variables in my own pager PHP page. Like so:

<button type="button" class="btn btn-dark" disabled><?= 'Page ' . $currentPage . ' of ' . $totalPages; ?></button>

My controller would fill-in these variables:

      $data = [
            ......,
            'pager'            => $someModel->pager,
            'currentPage' => $someModel->pager->getCurrentPage('group1'), // The current page number
            'totalPages'    => $someModel->pager->getPageCount('group1'),   // The total page count
      ];

This now leads to: Undefined variable $currentPage. How can I get this working again..? What do you advise here?

[kenjis]

<button type="button" class="btn btn-dark" disabled><?= 'Page ' . $pager->getCurrentPage('group1') 
. ' of ' . $pager->getPageCount('group1'); ?></button>