Bug: Builder insert()/update() does not accept an object

[blagi]

PHP Version

7.4

CodeIgniter4 Version

4.0.4

CodeIgniter4 Installation Method

Manual (zip or tar.gz)

Which operating systems have you tested for this bug?

Linux

Which server did you use?

apache

Database

MySQL 5.56

What happened?

Hi, I have a problem with DB Builder
Log:
CRITICAL - 2022-06-30 09:24:34 --> Argument 1 passed to CodeIgniter\Database\BaseBuilder::update() must be of the type array or null, object given, called in ....php on line 41

My mine 40 & line 41:

$builder = $this->dbmail->table(self::TABLE); 
$builder->update($undelivered, ['undelivered_id' => $undelivered->undelivered_id]); 

According to documentation:

$object = new Myclass(); 
$builder->where('id', $id); 
$builder->update($object); 

https://codeigniter4.github.io/CodeIgniter4/database/query_builder.html#builder-update

Builder insert() have a same problem.

Steps to Reproduce

Just do Builder update with object.

Expected Output

No critical or any other error

Anything else?

Looks like the error is in all versions from 4.0.4 until current

[iRedds]

1. You should update the framework. Preferably up to the latest version, as many bugs and vulnerabilities have been fixed.
2. This is a documentation error. The update() and insert() methods currently only expect arrays.
   You can use the set() method to pass data instead of passing it to the update()/insert() methods.

$builder->set($object)->where()->update();

[kenjis]

The API is changed a bit, but an object can be inserted since v3.
https://www.codeigniter.com/userguide3/database/query_builder.html#inserting-data

I think this is a bug of the implementation and should be fixed.