Skip to content

parseRequestURI dose not override globals['server'] ? #3976

@bananacoffee

Description

@bananacoffee

When $_SERVER['QUERY_STRING'] is override at parseRequestURI.

# system/HTTP/IncomingRequest.php
if (trim($uri, '/') === '' && strncmp($query, '/', 1) === 0)
{
	$query                   = explode('?', $query, 2);
	$uri                     = $query[0];
	$_SERVER['QUERY_STRING'] = $query[1] ?? '';
}
else
{
	$_SERVER['QUERY_STRING'] = $query;
}

Then $_SERVER['QUERY_STRING'] returns new value but $request->getServer('QUERY_STRING') returns old value.

Is this the correct behavior?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions