Configure php_unit_data_provider_return_type fixer

Author: paulbalandan

.php-cs-fixer.dist.php

@@ -43,7 +43,9 @@
         __DIR__ . '/spark',
     ]);
 
-$overrides = [];
+$overrides = [
+    'php_unit_data_provider_return_type' => true,
+];
 
 $options = [
     'cacheFile'    => 'build/.php-cs-fixer.cache',

.php-cs-fixer.no-header.php

@@ -29,7 +29,9 @@
         __DIR__ . '/admin/starter/builds',
     ]);
 
-$overrides = [];
+$overrides = [
+    'php_unit_data_provider_return_type' => true,
+];
 
 $options = [
     'cacheFile'    => 'build/.php-cs-fixer.no-header.cache',

.php-cs-fixer.user-guide.php

@@ -29,10 +29,11 @@
     ]);
 
 $overrides = [
-    'echo_tag_syntax'             => false,
-    'php_unit_internal_class'     => false,
-    'no_unused_imports'           => false,
-    'class_attributes_separation' => false,
+    'echo_tag_syntax'                    => false,
+    'php_unit_internal_class'            => false,
+    'no_unused_imports'                  => false,
+    'class_attributes_separation'        => false,
+    'php_unit_data_provider_return_type' => true,
 ];
 
 $options = [

tests/system/CLI/CLITest.php

@@ -463,7 +463,7 @@ public function testTable($tbody, $thead, $expected)
         $this->assertSame($this->getStreamFilterBuffer(), $expected);
     }
 
-    public function tableProvider()
+    public function tableProvider(): iterable
     {
         $head = [
             'ID',

tests/system/Cache/Handlers/BaseHandlerTest.php

@@ -35,7 +35,7 @@ public function testValidateKeyInvalidType($input)
         BaseHandler::validateKey($input);
     }
 
-    public function invalidTypeProvider(): array
+    public function invalidTypeProvider(): iterable
     {
         return [
             [true],

tests/system/Cache/Handlers/FileHandlerTest.php

@@ -296,7 +296,7 @@ public function testSaveMode(int $int, string $string): void
         $this->assertSame($string, $mode);
     }
 
-    public function modeProvider()
+    public function modeProvider(): iterable
     {
         return [
             [

tests/system/CodeIgniterTest.php

@@ -789,7 +789,7 @@ public function testPageCacheWithCacheQueryString($cacheQueryStringValue, int $e
         CITestStreamFilter::removeErrorFilter();
     }
 
-    public function cacheQueryStringProvider(): array
+    public function cacheQueryStringProvider(): iterable
     {
         $testingUrls = [
             'test', // URL #1

tests/system/Commands/CommandTest.php

@@ -138,7 +138,7 @@ public function testCommandParsesArgsCorrectly(string $input, array $expected)
         $this->assertSame($expected, ParamsReveal::$args);
     }
 
-    public function commandArgsProvider(): array
+    public function commandArgsProvider(): iterable
     {
         return [
             [

tests/system/Commands/Utilities/Routes/SampleURIGeneratorTest.php

@@ -13,7 +13,6 @@
 
 use CodeIgniter\Config\Services;
 use CodeIgniter\Test\CIUnitTestCase;
-use Generator;
 
 /**
  * @internal
@@ -34,7 +33,7 @@ public function testGet(string $routeKey, string $expected)
         $this->assertSame($expected, $uri);
     }
 
-    public function routeKeyProvider(): Generator
+    public function routeKeyProvider(): iterable
     {
         yield from [
             'root'                => ['/', '/'],

tests/system/CommonFunctionsTest.php

@@ -604,7 +604,7 @@ public function testCleanPathActuallyCleaningThePaths($input, $expected)
         $this->assertSame($expected, clean_path($input));
     }
 
-    public function dirtyPathsProvider()
+    public function dirtyPathsProvider(): iterable
     {
         $ds = DIRECTORY_SEPARATOR;