test: replace public with private

kenjis · kenjis · commit f211714cfd60 · 2022-06-28T07:08:19.000+09:00
diff --git a/tests/system/CLI/ConsoleTest.php b/tests/system/CLI/ConsoleTest.php
@@ -25,9 +25,9 @@
 final class ConsoleTest extends CIUnitTestCase
 {
     /**
-     * @var DotEnv|mixed
+     * @var DotEnv
      */
-    public $env;
+    private $env;
 
     private $stream_filter;
 
diff --git a/tests/system/CommonFunctionsTest.php b/tests/system/CommonFunctionsTest.php
@@ -44,9 +44,9 @@
 final class CommonFunctionsTest extends CIUnitTestCase
 {
     /**
-     * @var App|mixed
+     * @var App
      */
-    public $config;
+    private $config;
 
     public MockIncomingRequest $request;
 
diff --git a/tests/system/Config/DotEnvTest.php b/tests/system/Config/DotEnvTest.php
@@ -25,9 +25,9 @@
 final class DotEnvTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|vfsStreamDirectory|null
+     * @var vfsStreamDirectory|null
      */
-    public $root;
+    private $root;
 
     public string $path;
     private $fixturesFolder;
diff --git a/tests/system/ControllerTest.php b/tests/system/ControllerTest.php
@@ -34,9 +34,9 @@
 final class ControllerTest extends CIUnitTestCase
 {
     /**
-     * @var App|mixed
+     * @var App
      */
-    public $config;
+    private $config;
 
     /**
      * @var Controller
diff --git a/tests/system/Database/Live/MetadataTest.php b/tests/system/Database/Live/MetadataTest.php
@@ -27,9 +27,9 @@ final class MetadataTest extends CIUnitTestCase
     use DatabaseTestTrait;
 
     /**
-     * @var Forge|mixed
+     * @var Forge
      */
-    public $forge;
+    private $forge;
 
     protected $refresh = true;
     protected $seed    = CITestSeeder::class;
diff --git a/tests/system/HTTP/ContentSecurityPolicyTest.php b/tests/system/HTTP/ContentSecurityPolicyTest.php
@@ -28,14 +28,14 @@
 final class ContentSecurityPolicyTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|Response
+     * @var Response
      */
-    public $response;
+    private $response;
 
     /**
-     * @var \CodeIgniter\HTTP\ContentSecurityPolicy|mixed
+     * @var \CodeIgniter\HTTP\ContentSecurityPolicy
      */
-    public $csp;
+    private $csp;
 
     // Having this method as setUp() doesn't work - can't find Config\App !?
     protected function prepare(bool $CSPEnabled = true)
diff --git a/tests/system/HTTP/Files/FileMovingTest.php b/tests/system/HTTP/Files/FileMovingTest.php
@@ -22,21 +22,21 @@
 final class FileMovingTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|vfsStreamDirectory|null
+     * @var vfsStreamDirectory|null
      */
-    public $root;
+    private $root;
 
     public string $path;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $start;
+    private $start;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $destination;
+    private $destination;
 
     protected function setUp(): void
     {
diff --git a/tests/system/Helpers/FilesystemHelperTest.php b/tests/system/Helpers/FilesystemHelperTest.php
@@ -23,7 +23,7 @@ final class FilesystemHelperTest extends CIUnitTestCase
     /**
      * @var array<string, array<string, mixed[]>>|array<string, array<string, string>>|array<string, mixed>|array<string, mixed[]>|array<string, string>|mixed
      */
-    public $structure;
+    private $structure;
 
     protected function setUp(): void
     {
diff --git a/tests/system/Images/BaseHandlerTest.php b/tests/system/Images/BaseHandlerTest.php
@@ -32,24 +32,24 @@
 final class BaseHandlerTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|vfsStreamDirectory
+     * @var vfsStreamDirectory
      */
-    public $root;
+    private $root;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $origin;
+    private $origin;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $start;
+    private $start;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $path;
+    private $path;
 
     protected function setUp(): void
     {
diff --git a/tests/system/Images/GDHandlerTest.php b/tests/system/Images/GDHandlerTest.php
@@ -32,29 +32,29 @@
 final class GDHandlerTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|vfsStreamDirectory
+     * @var vfsStreamDirectory
      */
-    public $root;
+    private $root;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $origin;
+    private $origin;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $start;
+    private $start;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $path;
+    private $path;
 
     /**
-     * @var BaseHandler|mixed
+     * @var BaseHandler
      */
-    public $handler;
+    private $handler;
 
     protected function setUp(): void
     {
diff --git a/tests/system/Images/ImageMagickHandlerTest.php b/tests/system/Images/ImageMagickHandlerTest.php
@@ -32,24 +32,24 @@
 final class ImageMagickHandlerTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $root;
+    private $root;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $origin;
+    private $origin;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $path;
+    private $path;
 
     /**
-     * @var BaseHandler|mixed
+     * @var BaseHandler
      */
-    public $handler;
+    private $handler;
 
     protected function setUp(): void
     {
diff --git a/tests/system/Images/ImageTest.php b/tests/system/Images/ImageTest.php
@@ -22,21 +22,21 @@
 final class ImageTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|vfsStreamDirectory
+     * @var vfsStreamDirectory
      */
-    public $root;
+    private $root;
 
     public string $origin;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $start;
+    private $start;
 
     /**
-     * @var Image|mixed
+     * @var Image
      */
-    public $image;
+    private $image;
 
     protected function setUp(): void
     {
diff --git a/tests/system/Log/Handlers/FileHandlerTest.php b/tests/system/Log/Handlers/FileHandlerTest.php
@@ -24,14 +24,14 @@
 final class FileHandlerTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|vfsStreamDirectory
+     * @var vfsStreamDirectory
      */
-    public $root;
+    private $root;
 
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $start;
+    private $start;
 
     protected function setUp(): void
     {
diff --git a/tests/system/Pager/PagerRendererTest.php b/tests/system/Pager/PagerRendererTest.php
@@ -20,9 +20,9 @@
 final class PagerRendererTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|string
+     * @var string
      */
-    public $expect;
+    private $expect;
 
     private URI $uri;
 
diff --git a/tests/system/Test/TestCaseTest.php b/tests/system/Test/TestCaseTest.php
@@ -23,9 +23,9 @@
 final class TestCaseTest extends CIUnitTestCase
 {
     /**
-     * @var bool|mixed|resource
+     * @var bool|resource
      */
-    public $stream_filter;
+    private $stream_filter;
 
     public function testGetPrivatePropertyWithObject()
     {
diff --git a/tests/system/Throttle/ThrottleTest.php b/tests/system/Throttle/ThrottleTest.php
@@ -20,9 +20,9 @@
 final class ThrottleTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|MockCache
+     * @var Cache
      */
-    public $cache;
+    private $cache;
 
     protected function setUp(): void
     {
diff --git a/tests/system/View/TableTest.php b/tests/system/View/TableTest.php
@@ -22,9 +22,9 @@
 final class TableTest extends CIUnitTestCase
 {
     /**
-     * @var mixed|MockTable
+     * @var Table
      */
-    public $table;
+    private $table;
 
     protected function setUp(): void
     {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ final class FilesystemHelperTest extends CIUnitTestCase`
`23`	`23`	`/**`
`24`	`24`	`* @var array<string, array<string, mixed[]>>\|array<string, array<string, string>>\|array<string, mixed>\|array<string, mixed[]>\|array<string, string>\|mixed`
`25`	`25`	`*/`
`26`		`- public $structure;`
	`26`	`+ private $structure;`
`27`	`27`
`28`	`28`	`protected function setUp(): void`
`29`	`29`	`{`