refactor: extract method

Author: kenjis

system/Commands/Utilities/Routes/AutoRouterImproved/ControllerMethodReader.php

@@ -85,23 +85,7 @@ public function read(string $class, string $defaultController = 'Home', string $
                             continue;
                         }
 
-                        $params      = [];
-                        $routeParams = '';
-                        $refParams   = $method->getParameters();
-
-                        foreach ($refParams as $param) {
-                            $required = true;
-                            if ($param->isOptional()) {
-                                $required = false;
-
-                                $routeParams .= '[/..]';
-                            } else {
-                                $routeParams .= '/..';
-                            }
-
-                            // [variable_name => required?]
-                            $params[$param->getName()] = $required;
-                        }
+                        [$params, $routeParams] = $this->getParameters($method);
 
                         // Route for the default method.
                         $output[] = [
@@ -117,23 +101,7 @@ public function read(string $class, string $defaultController = 'Home', string $
 
                     $route = $classInUri . '/' . $methodInUri;
 
-                    $params      = [];
-                    $routeParams = '';
-                    $refParams   = $method->getParameters();
-
-                    foreach ($refParams as $param) {
-                        $required = true;
-                        if ($param->isOptional()) {
-                            $required = false;
-
-                            $routeParams .= '[/..]';
-                        } else {
-                            $routeParams .= '/..';
-                        }
-
-                        // [variable_name => required?]
-                        $params[$param->getName()] = $required;
-                    }
+                    [$params, $routeParams] = $this->getParameters($method);
 
                     // If it is the default controller, the method will not be
                     // routed.
@@ -155,6 +123,29 @@ public function read(string $class, string $defaultController = 'Home', string $
         return $output;
     }
 
+    private function getParameters(ReflectionMethod $method): array
+    {
+        $params      = [];
+        $routeParams = '';
+        $refParams   = $method->getParameters();
+
+        foreach ($refParams as $param) {
+            $required = true;
+            if ($param->isOptional()) {
+                $required = false;
+
+                $routeParams .= '[/..]';
+            } else {
+                $routeParams .= '/..';
+            }
+
+            // [variable_name => required?]
+            $params[$param->getName()] = $required;
+        }
+
+        return [$params, $routeParams];
+    }
+
     /**
      * @phpstan-param class-string $classname
      *