refactor: by rector

kenjis · kenjis · commit e8e7a6b36775 · 2023-03-24T13:19:57.000+09:00
diff --git a/system/Database/Postgre/Forge.php b/system/Database/Postgre/Forge.php
@@ -110,10 +110,8 @@ protected function _alterTable(string $alterType, string $table, $field)
             }
 
             $nullable = true; // Nullable by default.
-            if (isset($data['null'])) {
-                if ($data['null'] === false || $data['null'] === ' NOT ' . $this->null) {
-                    $nullable = false;
-                }
+            if (isset($data['null']) && ($data['null'] === false || $data['null'] === ' NOT ' . $this->null)) {
+                $nullable = false;
             }
             $sqls[] = $sql . ' ALTER COLUMN ' . $this->db->escapeIdentifiers($data['name'])
                 . ($nullable === true ? ' DROP' : ' SET') . ' NOT NULL';
diff --git a/system/Database/SQLSRV/Forge.php b/system/Database/SQLSRV/Forge.php
@@ -204,10 +204,8 @@ protected function _alterTable(string $alterType, string $table, $field)
             }
 
             $nullable = true; // Nullable by default.
-            if (isset($data['null'])) {
-                if ($data['null'] === false || $data['null'] === ' NOT ' . $this->null) {
-                    $nullable = false;
-                }
+            if (isset($data['null']) && ($data['null'] === false || $data['null'] === ' NOT ' . $this->null)) {
+                $nullable = false;
             }
             $sqls[] = $sql . ' ALTER COLUMN ' . $this->db->escapeIdentifiers($data['name'])
                 . " {$data['type']}{$data['length']} " . ($nullable === true ? '' : 'NOT') . ' NULL';

Original file line number	Diff line number	Diff line change
`@@ -110,10 +110,8 @@ protected function _alterTable(string $alterType, string $table, $field)`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`$nullable = true; // Nullable by default.`
`113`		`- if (isset($data['null'])) {`
`114`		`- if ($data['null'] === false \|\| $data['null'] === ' NOT ' . $this->null) {`
`115`		`- $nullable = false;`
`116`		`- }`
	`113`	`+ if (isset($data['null']) && ($data['null'] === false \|\| $data['null'] === ' NOT ' . $this->null)) {`
	`114`	`+ $nullable = false;`
`117`	`115`	`}`
`118`	`116`	`$sqls[] = $sql . ' ALTER COLUMN ' . $this->db->escapeIdentifiers($data['name'])`
`119`	`117`	`. ($nullable === true ? ' DROP' : ' SET') . ' NOT NULL';`
Original file line number	Diff line number	Diff line change
`@@ -204,10 +204,8 @@ protected function _alterTable(string $alterType, string $table, $field)`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`$nullable = true; // Nullable by default.`
`207`		`- if (isset($data['null'])) {`
`208`		`- if ($data['null'] === false \|\| $data['null'] === ' NOT ' . $this->null) {`
`209`		`- $nullable = false;`
`210`		`- }`
	`207`	`+ if (isset($data['null']) && ($data['null'] === false \|\| $data['null'] === ' NOT ' . $this->null)) {`
	`208`	`+ $nullable = false;`
`211`	`209`	`}`
`212`	`210`	`$sqls[] = $sql . ' ALTER COLUMN ' . $this->db->escapeIdentifiers($data['name'])`
`213`	`211`	`. " {$data['type']}{$data['length']} " . ($nullable === true ? '' : 'NOT') . ' NULL';`