test: ensure all test methods have native return types (#9565)

Author: paulbalandan

.php-cs-fixer.tests.php

@@ -31,7 +31,8 @@
     ->notName('#Foobar.php$#');
 
 $overrides = [
-    'void_return' => true,
+    'phpdoc_to_return_type' => true,
+    'void_return'           => true,
 ];
 
 return $config

tests/_support/Autoloader/FatalLocator.php

@@ -34,7 +34,7 @@ class FatalLocator extends FileLocator
      *
      * @return false|string The path to the file, or false if not found.
      */
-    public function locateFile(string $file, ?string $folder = null, string $ext = 'php')
+    public function locateFile(string $file, ?string $folder = null, string $ext = 'php'): false|string
     {
         $folder ??= 'null';
 

tests/_support/Config/Services.php

@@ -31,10 +31,8 @@ class Services extends BaseServices
      * The URI class provides a way to model and manipulate URIs.
      *
      * @param string|null $uri The URI string
-     *
-     * @return URI
      */
-    public static function uri(?string $uri = null, bool $getShared = true)
+    public static function uri(?string $uri = null, bool $getShared = true): URI
     {
         // Intercept our test case
         if ($uri === 'testCanReplaceFrameworkServices') {

tests/_support/Entity/Cast/CastPassParameters.php

@@ -22,10 +22,8 @@ class CastPassParameters extends BaseCast
      *
      * @param mixed $value  Data
      * @param array $params Additional param
-     *
-     * @return mixed
      */
-    public static function set($value, array $params = [])
+    public static function set($value, array $params = []): string
     {
         return $value . ':' . json_encode($params);
     }

tests/system/Files/FileTest.php

@@ -172,7 +172,7 @@ public function testGetDestination(): void
     /**
      * @return array<string, array<int, FileSizeUnit>>
      */
-    public static function provideGetSizeData()
+    public static function provideGetSizeData(): array
     {
         return [
             'returns KB binary' => [

tests/system/Models/TimestampModelTest.php

@@ -40,7 +40,7 @@ protected function tearDown(): void
     /**
      * @return int|string Insert ID
      */
-    private function allowDatesPrepareOneRecord(array $data)
+    private function allowDatesPrepareOneRecord(array $data): int|string
     {
         $this->createModel(UserTimestampModel::class);
         $this->db->table('user')->truncate();
@@ -60,7 +60,7 @@ private function allowDatesPrepareOneRecord(array $data)
     /**
      * @return int|string Insert ID
      */
-    private function doNotAllowDatesPrepareOneRecord(array $data)
+    private function doNotAllowDatesPrepareOneRecord(array $data): int|string
     {
         $this->createModel(UserTimestampModel::class);
         $this->db->table('user')->truncate();

tests/system/Test/BootstrapFCPATHTest.php

@@ -100,10 +100,7 @@ private function fileContents(): string
         return $fileContents . 'echo FCPATH;' . PHP_EOL;
     }
 
-    /**
-     * @return false|string
-     */
-    private function readOutput(string $file)
+    private function readOutput(string $file): false|string
     {
         ob_start();
         system('php -f ' . $file);