refactor: extract setCreatedField() and setUpdatedField()

Author: kenjis

system/BaseModel.php

@@ -784,14 +784,8 @@ public function insert($data = null, bool $returnID = true)
 
         // Set created_at and updated_at with same time
         $date = $this->setDate();
-
-        if ($this->useTimestamps && $this->createdField !== '' && ! array_key_exists($this->createdField, $data)) {
-            $data[$this->createdField] = $date;
-        }
-
-        if ($this->useTimestamps && $this->updatedField !== '' && ! array_key_exists($this->updatedField, $data)) {
-            $data[$this->updatedField] = $date;
-        }
+        $data = $this->setCreatedField($data, $date);
+        $data = $this->setUpdatedField($data, $date);
 
         $eventData = ['data' => $data];
 
@@ -823,6 +817,36 @@ public function insert($data = null, bool $returnID = true)
         return $returnID ? $this->insertID : $result;
     }
 
+    /**
+     * Set datetime to created field.
+     *
+     * @phpstan-param row_array $row
+     * @param int|string $date timestamp or datetime string
+     */
+    protected function setCreatedField(array $row, $date): array
+    {
+        if ($this->useTimestamps && $this->createdField !== '' && ! array_key_exists($this->createdField, $row)) {
+            $row[$this->createdField] = $date;
+        }
+
+        return $row;
+    }
+
+    /**
+     * Set datetime to updated field.
+     *
+     * @phpstan-param row_array $row
+     * @param int|string $date timestamp or datetime string
+     */
+    protected function setUpdatedField(array $row, $date): array
+    {
+        if ($this->useTimestamps && $this->updatedField !== '' && ! array_key_exists($this->updatedField, $row)) {
+            $row[$this->updatedField] = $date;
+        }
+
+        return $row;
+    }
+
     /**
      * Compiles batch insert runs the queries, validating each row prior.
      *
@@ -872,14 +896,8 @@ public function insertBatch(?array $set = null, ?bool $escape = null, int $batch
 
                 // Set created_at and updated_at with same time
                 $date = $this->setDate();
-
-                if ($this->useTimestamps && $this->createdField !== '' && ! array_key_exists($this->createdField, $row)) {
-                    $row[$this->createdField] = $date;
-                }
-
-                if ($this->useTimestamps && $this->updatedField !== '' && ! array_key_exists($this->updatedField, $row)) {
-                    $row[$this->updatedField] = $date;
-                }
+                $row  = $this->setCreatedField($row, $date);
+                $row  = $this->setUpdatedField($row, $date);
             }
         }
 
@@ -946,9 +964,7 @@ public function update($id = null, $data = null): bool
             throw DataException::forEmptyDataset('update');
         }
 
-        if ($this->useTimestamps && $this->updatedField !== '' && ! array_key_exists($this->updatedField, $data)) {
-            $data[$this->updatedField] = $this->setDate();
-        }
+        $data = $this->setUpdatedField($data, $this->setDate());
 
         $eventData = [
             'id'   => $id,
@@ -1032,9 +1048,7 @@ public function updateBatch(?array $set = null, ?string $index = null, int $batc
                     $row[$index] = $updateIndex;
                 }
 
-                if ($this->useTimestamps && $this->updatedField !== '' && ! array_key_exists($this->updatedField, $row)) {
-                    $row[$this->updatedField] = $this->setDate();
-                }
+                $row = $this->setUpdatedField($row, $this->setDate());
             }
         }
 
@@ -1166,9 +1180,7 @@ public function replace(?array $data = null, bool $returnSQL = false)
             return false;
         }
 
-        if ($this->useTimestamps && $this->updatedField !== '' && ! array_key_exists($this->updatedField, (array) $data)) {
-            $data[$this->updatedField] = $this->setDate();
-        }
+        $data = $this->setUpdatedField((array) $data, $this->setDate());
 
         return $this->doReplace($data, $returnSQL);
     }