Merge remote-tracking branch 'upstream/develop' into 4.4

Author: kenjis

tests/system/ControllerTest.php

@@ -23,7 +23,6 @@
 use Config\Services;
 use Config\Validation as ValidationConfig;
 use Psr\Log\LoggerInterface;
-use Tests\Support\Config\Validation;
 
 /**
  * Exercise our core Controller class.

tests/system/Database/Live/SQLite/AlterTableTest.php

@@ -12,7 +12,6 @@
 namespace CodeIgniter\Database\Live\SQLite;
 
 use CodeIgniter\Database\Exceptions\DataException;
-use CodeIgniter\Database\SQLite3\Connection;
 use CodeIgniter\Database\SQLite3\Forge;
 use CodeIgniter\Database\SQLite3\Table;
 use CodeIgniter\Test\CIUnitTestCase;

tests/system/I18n/TimeLegacyTest.php

@@ -1125,16 +1125,16 @@ public function testGetter()
     }
 
     // @TODO Uncomment when PHP 8.2.4 Segmentation fault fixed.
-//    public function testUnserializeTimeObject()
-//    {
-//        $time1     = new TimeLegacy('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
-//        $timeCache = serialize($time1);
-//        $time2     = unserialize($timeCache);
-//
-//        $this->assertInstanceOf(TimeLegacy::class, $time2);
-//        $this->assertTrue($time2->equals($time1));
-//        $this->assertNotSame($time1, $time2);
-//    }
+    //    public function testUnserializeTimeObject()
+    //    {
+    //        $time1     = new TimeLegacy('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
+    //        $timeCache = serialize($time1);
+    //        $time2     = unserialize($timeCache);
+    //
+    //        $this->assertInstanceOf(TimeLegacy::class, $time2);
+    //        $this->assertTrue($time2->equals($time1));
+    //        $this->assertNotSame($time1, $time2);
+    //    }
 
     public function testSetTestNowWithFaLocale()
     {

tests/system/I18n/TimeTest.php

@@ -1128,16 +1128,16 @@ public function testGetter()
     }
 
     // @TODO Uncomment when PHP 8.2.4 Segmentation fault fixed.
-//    public function testUnserializeTimeObject()
-//    {
-//        $time1     = new Time('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
-//        $timeCache = serialize($time1);
-//        $time2     = unserialize($timeCache);
-//
-//        $this->assertInstanceOf(Time::class, $time2);
-//        $this->assertTrue($time2->equals($time1));
-//        $this->assertNotSame($time1, $time2);
-//    }
+    //    public function testUnserializeTimeObject()
+    //    {
+    //        $time1     = new Time('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
+    //        $timeCache = serialize($time1);
+    //        $time2     = unserialize($timeCache);
+    //
+    //        $this->assertInstanceOf(Time::class, $time2);
+    //        $this->assertTrue($time2->equals($time1));
+    //        $this->assertNotSame($time1, $time2);
+    //    }
 
     public function testSetTestNowWithTimeZone()
     {

tests/system/Session/Handlers/Database/RedisHandlerTest.php

@@ -16,7 +16,6 @@
 use CodeIgniter\Test\CIUnitTestCase;
 use Config\App as AppConfig;
 use Config\Session as SessionConfig;
-use Redis;
 
 /**
  * @group DatabaseLive